Prevent pinTags + minInstances from any functions, not just frameworks (#6684)

inlined · web-flow · commit d5a179a7ae81 · 2024-01-16T08:38:30.000-08:00
* Prevent pinTags + minInstances from any functions rewrite, not just web frameworks

* Changelog

* Changelog formatting
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+Prevent the use of pinTags + minInstances on the same function, as the features are not mutually compatible (#6684)
diff --git a/src/deploy/hosting/convertConfig.ts b/src/deploy/hosting/convertConfig.ts
@@ -218,6 +218,19 @@ export async function convertConfig(
         },
       };
       if (rewrite.function.pinTag) {
+        // b/319616292. Functions currently set min instances at the revision
+        // level and Run will maintain all those min instances for each revision
+        // whenever that revision is accessible (e.g. via a traffic tag). This
+        // can lead to customers paying lots of money with zero benefit. Until
+        // Run makes min instances dynamic, we must not allow both features to
+        // be used at the same time.
+        if (endpoint.minInstances) {
+          throw new FirebaseError(
+            `Function ${endpoint.id} has minInstances set and is in a rewrite ` +
+              "pinTags=true. These features are not currently compatible with each " +
+              "other."
+          );
+        }
         experiments.assertEnabled("pintags", "pin a function version");
         apiRewrite.run.tag = runTags.TODO_TAG_NAME;
       }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Prevent the use of pinTags + minInstances on the same function, as the features are not mutually compatible (#6684)`