Fix frameworks deploy to preview channel (#6025)

hsubox76 · web-flow · commit 29747a824caa · 2023-06-23T10:18:06.000-07:00
diff --git a/src/deploy/hosting/prepare.ts b/src/deploy/hosting/prepare.ts
@@ -12,6 +12,7 @@ import * as utils from "../../utils";
 import { HostingSource, RunRewrite } from "../../firebaseConfig";
 import * as backend from "../functions/backend";
 import { ensureTargeted } from "../../functions/ensureTargeted";
+import { generateSSRCodebaseId } from "../../frameworks";
 
 function handlePublicDirectoryFlag(options: HostingOptions & Options): void {
   // Allow the public directory to be overridden by the --public flag
@@ -74,6 +75,12 @@ export async function addPinnedFunctionsToOnlyString(
       ]?.[r.function.functionId];
       if (endpoint) {
         options.only = ensureTargeted(options.only, endpoint.codebase || "default", endpoint.id);
+      } else if (c.webFramework) {
+        options.only = ensureTargeted(
+          options.only,
+          generateSSRCodebaseId(c.site),
+          r.function.functionId
+        );
       } else {
         // This endpoint is just being added in this push. We don't know what codebase it is.
         options.only = ensureTargeted(options.only, r.function.functionId);
diff --git a/src/frameworks/index.ts b/src/frameworks/index.ts
@@ -104,6 +104,14 @@ function memoizeBuild(
   return value;
 }
 
+/**
+ * Use a function to ensure the same codebase name is used here and
+ * during hosting deploy.
+ */
+export function generateSSRCodebaseId(site: string) {
+  return `firebase-frameworks-${site}`;
+}
+
 /**
  *
  */
@@ -330,7 +338,7 @@ export async function prepareFrameworks(
         );
       }
 
-      const codebase = `firebase-frameworks-${site}`;
+      const codebase = generateSSRCodebaseId(site);
       const existingFunctionsConfig = options.config.get("functions")
         ? [].concat(options.config.get("functions"))
         : [];
