Set a reasonable default dataconnect generated SDK output path (#7406)

fredzqm · web-flow · commit 282eafd007ff · 2024-07-02T18:02:56.000Z
* provide a default gen sdk output path

* fix relative path

* changelog

* Update sdk.ts
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1 +1,2 @@
 - Fixes framework support for Nuxt ^3.12 by correctly calling loadNuxtConfig() (#7375)
+- Add a default for `firebase init dataconnect:sdk` (#7406)
diff --git a/src/init/features/dataconnect/sdk.ts b/src/init/features/dataconnect/sdk.ts
@@ -59,11 +59,12 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> {
   }
 
   if (platforms.includes(IOS)) {
-    const defaultOutputDir = newConnectorYaml.generate.swiftSdk?.outputDir;
     const outputDir = await promptOnce({
       message: `What directory do you want to write your Swift SDK code to? (If not absolute, path will be relative to '${connectorInfo.directory}')`,
       type: "input",
-      default: defaultOutputDir,
+      default:
+        newConnectorYaml.generate.swiftSdk?.outputDir ||
+        `./../.dataconnect/generated/${newConnectorYaml.connectorId}/swift-sdk`,
     });
     const swiftSdk = { outputDir };
     newConnectorYaml.generate.swiftSdk = swiftSdk;
@@ -72,7 +73,9 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> {
     const outputDir = await promptOnce({
       message: `What directory do you want to write your JavaScript SDK code to? (If not absolute, path will be relative to '${connectorInfo.directory}')`,
       type: "input",
-      default: newConnectorYaml.generate.javascriptSdk?.outputDir,
+      default:
+        newConnectorYaml.generate.javascriptSdk?.outputDir ||
+        `./../.dataconnect/generated/${newConnectorYaml.connectorId}/javascript-sdk`,
     });
     const pkg = await promptOnce({
       message: "What package name do you want to use for your JavaScript SDK?",
@@ -101,7 +104,9 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> {
     const outputDir = await promptOnce({
       message: `What directory do you want to write your Kotlin SDK code to? (If not absolute, path will be relative to '${connectorInfo.directory}')`,
       type: "input",
-      default: newConnectorYaml.generate.kotlinSdk?.outputDir,
+      default:
+        newConnectorYaml.generate.kotlinSdk?.outputDir ||
+        `./../.dataconnect/generated/${newConnectorYaml.connectorId}/kotlin-sdk/src/main/kotlin/${newConnectorYaml.connectorId}`,
     });
     const pkg = await promptOnce({
       message: "What package name do you want to use for your Kotlin SDK?",

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`	`1`	`- Fixes framework support for Nuxt ^3.12 by correctly calling loadNuxtConfig() (#7375)`
	`2`	+- Add a default for `firebase init dataconnect:sdk` (#7406)