Skip to content

Remove deprecated sync -[FIRInstanceID appInstanceID:] method #4486

Closed

Description

@maksymmalyhin

The method must be removed and [FIRInstanceID appInstanceID:] , all usages must be replaced the the async alternative.

Activity

  1. added this to the Firebase 7 milestone on Dec 11, 2019
  2. charlotteliang commented on Apr 10, 2020

    @charlotteliang
    Member

    If other SDKs like analytic stop using this, we should remove it. Thanks for filing this!

  3. maksymmalyhin commented on May 11, 2020

    @maksymmalyhin
    ContributorAuthor

    All Firebase SDKs (except FCM so far) have been updated to use FIS directly, but the method may still be used in some 1P tests.

  4. charlotteliang commented on May 11, 2020

    @charlotteliang
    Member

    I think it's okay to remove it. I couldn't find any 1P depending on it anymore.
    Since it's a private API, is it considered a breaking change? ( I see we mark it firebase 7)

  5. paulb777 commented on May 11, 2020

    @paulb777
    Member

    We need to wait for Firebase 7 - because earlier Firebase 6 versions of other pods allow minor version updates of IID. If an old version of Firebase Analytics updates and this API is removed, the build will break.

  6. locked and limited conversation to collaborators on Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions