Remove creating copy of JSON object for experiment

athiramanu · athiramanu · commit 5ae478b32ab3 · 2026-04-06T20:00:37.000+05:30
diff --git a/firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigContainer.java b/firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigContainer.java
@@ -241,8 +241,8 @@ private Map<String, JSONObject> createExperimentsMap() throws JSONException {
       JSONArray affectedKeys = experiment.getJSONArray(AFFECTED_PARAMETER_KEYS);
       for (int j = 0; j < affectedKeys.length(); j++) {
         String key = affectedKeys.getString(j);
-        JSONObject experimentsCopy = new JSONObject(experiment.toString());
-        experimentsMap.put(key, experimentsCopy);
+        // Reuse the same JSONObject instance instead of creating a copy
+        experimentsMap.put(key, experiment);
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -241,8 +241,8 @@ private Map<String, JSONObject> createExperimentsMap() throws JSONException {`
`241`	`241`	`JSONArray affectedKeys = experiment.getJSONArray(AFFECTED_PARAMETER_KEYS);`
`242`	`242`	`for (int j = 0; j < affectedKeys.length(); j++) {`
`243`	`243`	`String key = affectedKeys.getString(j);`
`244`		`- JSONObject experimentsCopy = new JSONObject(experiment.toString());`
`245`		`- experimentsMap.put(key, experimentsCopy);`
	`244`	`+ // Reuse the same JSONObject instance instead of creating a copy`
	`245`	`+ experimentsMap.put(key, experiment);`
`246`	`246`	`}`
`247`	`247`	`}`
`248`	`248`