Use non-global app for db tests.

yuchenshi · yuchenshi · commit 31c1aa065c25 · 2019-07-31T17:46:36.000-07:00
diff --git a/integration/test_db.py b/integration/test_db.py
@@ -34,20 +34,27 @@ def integration_conf(request):
         return conftest.integration_conf(request)
 
 
-@pytest.fixture(autouse=True, scope='module')
-def default_app(request):
+@pytest.fixture(scope='module')
+def app(request):
     cred, project_id = integration_conf(request)
     ops = {
         'databaseURL' : 'https://{0}.firebaseio.com'.format(project_id),
     }
-    return firebase_admin.initialize_app(cred, ops)
+    return firebase_admin.initialize_app(cred, ops, name='integration-db')
+
+
+@pytest.fixture(scope='module', autouse=True)
+def default_app(request):
+    # Overwrites the default_app fixture in conftest.py.
+    # This test suite should not use the default app. Use the app fixture instead.
+    pass
 
 
 @pytest.fixture(scope='module')
-def update_rules():
+def update_rules(app):
     with open(testutils.resource_filename('dinosaurs_index.json')) as rules_file:
         new_rules = json.load(rules_file)
-    client = db.reference()._client
+    client = db.reference('', app)._client
     rules = client.body('get', '/.settings/rules.json')
     existing = rules.get('rules')
     if existing != new_rules:
@@ -60,7 +67,7 @@ def testdata():
         return json.load(dino_file)
 
 @pytest.fixture(scope='module')
-def testref(update_rules, testdata):
+def testref(update_rules, testdata, app):
     """Adds the necessary DB indices, and sets the initial values.
 
     This fixture is attached to the module scope, and therefore is guaranteed to run only once
@@ -70,7 +77,7 @@ def testref(update_rules, testdata):
         Reference: A reference to the test dinosaur database.
     """
     del update_rules
-    ref = db.reference('_adminsdk/python/dinodb')
+    ref = db.reference('_adminsdk/python/dinodb', app)
     ref.set(testdata)
     return ref
 
@@ -347,18 +354,18 @@ def none_override_app(request, update_rules):
 class TestAuthVariableOverride(object):
     """Test cases for database auth variable overrides."""
 
-    def init_ref(self, path):
-        admin_ref = db.reference(path)
+    def init_ref(self, path, app):
+        admin_ref = db.reference(path, app)
         admin_ref.set('test')
         assert admin_ref.get() == 'test'
 
     def check_permission_error(self, excinfo):
         assert isinstance(excinfo.value, db.ApiCallError)
         assert 'Reason: Permission denied' in str(excinfo.value)
 
-    def test_no_access(self, override_app):
+    def test_no_access(self, app, override_app):
         path = '_adminsdk/python/admin'
-        self.init_ref(path)
+        self.init_ref(path, app)
         user_ref = db.reference(path, override_app)
         with pytest.raises(db.ApiCallError) as excinfo:
             assert user_ref.get()
@@ -368,18 +375,18 @@ def test_no_access(self, override_app):
             user_ref.set('test2')
         self.check_permission_error(excinfo)
 
-    def test_read(self, override_app):
+    def test_read(self, app, override_app):
         path = '_adminsdk/python/protected/user2'
-        self.init_ref(path)
+        self.init_ref(path, app)
         user_ref = db.reference(path, override_app)
         assert user_ref.get() == 'test'
         with pytest.raises(db.ApiCallError) as excinfo:
             user_ref.set('test2')
         self.check_permission_error(excinfo)
 
-    def test_read_write(self, override_app):
+    def test_read_write(self, app, override_app):
         path = '_adminsdk/python/protected/user1'
-        self.init_ref(path)
+        self.init_ref(path, app)
         user_ref = db.reference(path, override_app)
         assert user_ref.get() == 'test'
         user_ref.set('test2')
@@ -391,9 +398,9 @@ def test_query(self, override_app):
             user_ref.order_by_key().limit_to_first(2).get()
         self.check_permission_error(excinfo)
 
-    def test_none_auth_override(self, none_override_app):
+    def test_none_auth_override(self, app, none_override_app):
         path = '_adminsdk/python/public'
-        self.init_ref(path)
+        self.init_ref(path, app)
         public_ref = db.reference(path, none_override_app)
         assert public_ref.get() == 'test'
 
