Revert "Gemini recommendation: use reportError inside the catch block"

megastep · megastep · commit fb92bc8bedf7 · 2026-03-30T13:31:06.000-07:00
This reverts commit d76f9fc.
diff --git a/FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/PasswordRecoveryView.swift b/FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/PasswordRecoveryView.swift
@@ -19,7 +19,6 @@ import SwiftUI
 @MainActor
 public struct PasswordRecoveryView {
   @Environment(AuthService.self) private var authService
-  @Environment(\.reportError) private var reportError
   @State private var email = ""
   @State private var showSuccessSheet = false
   @State private var sentEmail = ""
@@ -32,7 +31,7 @@ public struct PasswordRecoveryView {
       sentEmail = email
       showSuccessSheet = true
     } catch {
-      reportError?(error)
+      // Error already displayed via modal by AuthService
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ import SwiftUI`
`19`	`19`	`@MainActor`
`20`	`20`	`public struct PasswordRecoveryView {`
`21`	`21`	`@Environment(AuthService.self) private var authService`
`22`		`- @Environment(\.reportError) private var reportError`
`23`	`22`	`@State private var email = ""`
`24`	`23`	`@State private var showSuccessSheet = false`
`25`	`24`	`@State private var sentEmail = ""`
`@@ -32,7 +31,7 @@ public struct PasswordRecoveryView {`
`32`	`31`	`sentEmail = email`
`33`	`32`	`showSuccessSheet = true`
`34`	`33`	`} catch {`
`35`		`- reportError?(error)`
	`34`	`+ // Error already displayed via modal by AuthService`
`36`	`35`	`}`
`37`	`36`	`}`
`38`	`37`	`}`