fix: phone auth is isolated within package

russellwheatley · russellwheatley · commit 2769e037bacb · 2025-10-23T10:30:16.000+01:00
diff --git a/FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift b/FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift
@@ -108,42 +108,6 @@ public final class AuthService {
   public var currentMFARequired: MFARequired?
   private var currentMFAResolver: MultiFactorResolver?
 
-  // MARK: - AuthPickerView Modal APIs
-
-  public var isShowingAuthModal = false
-
-  public enum AuthModalContentType {
-    case phoneAuth
-  }
-
-  public var currentModal: AuthModalContentType?
-
-  public var authModalViewBuilderRegistry: [AuthModalContentType: () -> AnyView] = [:]
-
-  public func registerModalView(for type: AuthModalContentType,
-                                @ViewBuilder builder: @escaping () -> AnyView) {
-    authModalViewBuilderRegistry[type] = builder
-  }
-
-  public func viewForCurrentModal() -> AnyView? {
-    guard let type = currentModal,
-          let builder = authModalViewBuilderRegistry[type] else {
-      return nil
-    }
-    return builder()
-  }
-
-  public func presentModal(for type: AuthModalContentType) {
-    currentModal = type
-    isShowingAuthModal = true
-  }
-
-  public func dismissModal() {
-    isShowingAuthModal = false
-  }
-
-  // MARK: - End AuthPickerView Modal APIs
-
   // MARK: - Provider APIs
 
   private var listenerManager: AuthListenerManager?
diff --git a/FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift b/FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift
@@ -26,13 +26,6 @@ public struct AuthPickerView {
       .authenticationFlow == .signIn ? .signUp : .signIn
   }
 
-  private var isAuthModalPresented: Binding<Bool> {
-    Binding(
-      get: { authService.isShowingAuthModal },
-      set: { authService.isShowingAuthModal = $0 }
-    )
-  }
-
   @ViewBuilder
   private var authPickerTitleView: some View {
     if authService.authView == .authPicker {
@@ -103,33 +96,6 @@ extension AuthPickerView: View {
             EmptyView()
           }
         }
-      }.sheet(isPresented: isAuthModalPresented) {
-        VStack(spacing: 0) {
-          HStack {
-            Button(action: {
-              authService.dismissModal()
-            }) {
-              HStack(spacing: 4) {
-                Image(systemName: "chevron.left")
-                  .font(.system(size: 17, weight: .medium))
-                Text(authService.string.backButtonLabel)
-                  .font(.system(size: 17))
-              }
-              .foregroundColor(.blue)
-            }
-            Spacer()
-          }
-          .padding()
-          .background(Color(.systemBackground))
-
-          Divider()
-
-          if let view = authService.viewForCurrentModal() {
-            view
-              .frame(maxWidth: .infinity, maxHeight: .infinity)
-              .padding()
-          }
-        }
       }
     }
   }
diff --git a/FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/PhoneAuthProviderAuthUI.swift b/FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/PhoneAuthProviderAuthUI.swift
@@ -41,13 +41,31 @@ public class PhoneProviderSwift: PhoneAuthProviderSwift {
       .credential(withVerificationID: verificationID, verificationCode: verificationCode)
   }
 
-  // This method is required by the protocol but should not be used for phone auth
-  // Phone auth requires verification details, so use createPhoneAuthCredential instead
+  // Present phone auth UI and wait for user to complete the flow
   @MainActor public func createAuthCredential() async throws -> AuthCredential {
-    throw AuthServiceError
-      .invalidPhoneAuthenticationArguments(
-        "Phone auth requires verification details. Use createPhoneAuthCredential(verificationID:verificationCode:) instead."
-      )
+    guard let presentingViewController = await (UIApplication.shared.connectedScenes
+      .first as? UIWindowScene)?.windows.first?.rootViewController else {
+      throw AuthServiceError
+        .invalidPhoneAuthenticationArguments(
+          "Root View controller is not available to present Phone auth View."
+        )
+    }
+
+    return try await withCheckedThrowingContinuation { continuation in
+      let phoneAuthView = PhoneAuthView(phoneProvider: self) { result in
+        switch result {
+        case .success(let credential):
+          continuation.resume(returning: credential)
+        case .failure(let error):
+          continuation.resume(throwing: error)
+        }
+      }
+      
+      let hostingController = UIHostingController(rootView: phoneAuthView)
+      hostingController.modalPresentationStyle = .formSheet
+      
+      presentingViewController.present(hostingController, animated: true)
+    }
   }
 }
 
diff --git a/FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Views/PhoneAuthButtonView.swift b/FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Views/PhoneAuthButtonView.swift
@@ -29,10 +29,9 @@ public struct PhoneAuthButtonView {
 extension PhoneAuthButtonView: View {
   public var body: some View {
     Button(action: {
-      authService.registerModalView(for: .phoneAuth) {
-        AnyView(PhoneAuthView(phoneProvider: phoneProvider).environment(authService))
+      Task {
+        try await authService.signIn(phoneProvider)
       }
-      authService.presentModal(for: .phoneAuth)
     }) {
       Label("Sign in with Phone", systemImage: "phone.fill")
         .foregroundColor(.white)
diff --git a/FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Views/PhoneAuthView.swift b/FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Views/PhoneAuthView.swift
