create subscription before publishing a message

jabubake · jabubake · commit 011c88fa17fa · 2017-05-31T11:31:02.000-07:00
diff --git a/pubsub/cloud-client/README.md b/pubsub/cloud-client/README.md
@@ -15,9 +15,10 @@ For more samples, see the samples in
 
 #### Setup
 - Install [Maven](http://maven.apache.org/)
-- Install the [Google Cloud SDK](https://cloud.google.com/sdk/) and run :
+- Install the [Google Cloud SDK](https://cloud.google.com/sdk/) and authenticate  :
 ```
   gcloud config set project [YOUR PROJECT ID]
+  gcloud auth application-default login
 ```
 - [Enable](https://console.cloud.google.com/apis/api/pubsub.googleapis.com/overview) Pub/Sub API
 - Build your project with:
@@ -30,16 +31,16 @@ For more samples, see the samples in
   mvn exec:java -Dexec.mainClass=com.example.pubsub.CreateTopicExample -Dexec.args=my-topic-id
 ```
 
-#### Publish messages
+#### Create a subscription
 ```
-  mvn exec:java -Dexec.mainClass=com.example.pubsub.PublisherExample -Dexec.args=my-topic-id
+  mvn exec:java -Dexec.mainClass=com.example.pubsub.CreatePullSubscriptionExample -Dexec.args="my-topic-id my-subscription-id"
 ```
-Publishes 10 messages to the topic `my-topic-id`.
 
-#### Create a subscription
+#### Publish messages
 ```
-  mvn exec:java -Dexec.mainClass=com.example.pubsub.CreatePullSubscriptionExample -Dexec.args="my-topic-id my-subscription-id"
+  mvn exec:java -Dexec.mainClass=com.example.pubsub.PublisherExample -Dexec.args=my-topic-id
 ```
+Publishes 5 messages to the topic `my-topic-id`.
 
 #### Receive messages
 ```
diff --git a/pubsub/cloud-client/src/test/java/com/example/pubsub/QuickStartIT.java b/pubsub/cloud-client/src/test/java/com/example/pubsub/QuickStartIT.java
@@ -72,20 +72,20 @@ public void tearDown() throws Exception {
 
   @Test
   public void testQuickstart() throws Exception {
-    //create a topic
+    // create a topic
     CreateTopicExample.main(topicId);
     String got = bout.toString();
     assertThat(got).contains(topicId + " created.");
 
-    // publish messages
-    List<String> published = PublisherExample.publishMessages(topicId);
-    assertThat(published).hasSize(5);
-
     // create a subscriber
     CreatePullSubscriptionExample.main(topicId, subscriptionId);
     got = bout.toString();
     assertThat(got).contains(subscriptionId + " created.");
 
+    // publish messages
+    List<String> published = PublisherExample.publishMessages(topicId);
+    assertThat(published).hasSize(5);
+
     SubscriberExample subscriberExample = new SubscriberExample(subscriptionId);
     // receive messages
     Thread subscriberThread = new Thread(subscriberExample);
@@ -95,9 +95,9 @@ public void testQuickstart() throws Exception {
     while ((received = subscriberExample.getReceivedMessages()).size() < 5) {
       Thread.sleep(1000);
     }
+
     assertThat(received).containsAllIn(published);
     subscriberExample.stopSubscriber();
-    subscriberThread.join();
   }
 
   private String formatForTest(String name) {
