CLOUDSTACK-4459: need to sychronize create storage pool, otherwise, we can create the same pool with the same uuid in parallel

sudison · sudison · commit 9fa56e28ec0c · 2013-09-25T16:09:11.000-07:00
diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
@@ -173,7 +173,8 @@ public KVMStoragePool createStoragePool( String name, String host, int port,
         return createStoragePool(name, host, port, path, userInfo, type, true);
     }
 
-    private KVMStoragePool createStoragePool( String name, String host, int port,
+    //Note: due to bug CLOUDSTACK-4459, createStoragepool can be called in parallel, so need to be synced.
+    private synchronized KVMStoragePool createStoragePool( String name, String host, int port,
                                              String path, String userInfo,
                                              StoragePoolType type, boolean primaryStorage) {
         StorageAdaptor adaptor = getStorageAdaptor(type);

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,8 @@ public KVMStoragePool createStoragePool( String name, String host, int port,`
`173`	`173`	`return createStoragePool(name, host, port, path, userInfo, type, true);`
`174`	`174`	`}`
`175`	`175`
`176`		`- private KVMStoragePool createStoragePool( String name, String host, int port,`
	`176`	`+ //Note: due to bug CLOUDSTACK-4459, createStoragepool can be called in parallel, so need to be synced.`
	`177`	`+ private synchronized KVMStoragePool createStoragePool( String name, String host, int port,`
`177`	`178`	`String path, String userInfo,`
`178`	`179`	`StoragePoolType type, boolean primaryStorage) {`
`179`	`180`	`StorageAdaptor adaptor = getStorageAdaptor(type);`