findbugs: String.split() will not return nulls by contract

Daan Hoogland · Daan Hoogland · commit 7b105917584d · 2015-04-29T16:07:38.000+02:00
diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -867,7 +867,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
         if (cpuFeatures != null) {
             _cpuFeatures = new ArrayList<String>();
             for (String feature: cpuFeatures.split(" ")) {
-                if (feature != null || !feature.isEmpty()) {
+                if (!feature.isEmpty()) {
                     _cpuFeatures.add(feature);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -867,7 +867,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu`
`867`	`867`	`if (cpuFeatures != null) {`
`868`	`868`	`_cpuFeatures = new ArrayList<String>();`
`869`	`869`	`for (String feature: cpuFeatures.split(" ")) {`
`870`		`- if (feature != null \|\| !feature.isEmpty()) {`
	`870`	`+ if (!feature.isEmpty()) {`
`871`	`871`	`_cpuFeatures.add(feature);`
`872`	`872`	`}`
`873`	`873`	`}`