Skip to content

Commit 59db01c

Browse files
committed
CLOUDSTACK-1347: Don't enforce not null rule on queue_proc_time of sync_item_queue
In c63dbb8 I removed the rule from create-schema: - `queue_proc_time` datetime COMMENT 'when processing started for the item', But, upgrade path schema-40to410.sql had a different rule which caused the bug: +ALTER TABLE `cloud`.`sync_queue_item` ADD `queue_proc_time` DATETIME NOT NULL COMMENT 'when processing started for the item' AFTER `queue_proc_number`; In this fix we just revert to whatever rule was defined in create-schema as the developer may have forgetten to fix same rule in create-schema and upgrade path. This commit can be reverted or the code be fixed if we want that queue_proc_time cannot be null. Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
1 parent 7a3f072 commit 59db01c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

setup/db/db/schema-40to410.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ ALTER TABLE `cloud`.`sync_queue` DROP COLUMN `queue_proc_time`;
200200

201201
ALTER TABLE `cloud`.`sync_queue` DROP COLUMN `queue_proc_msid`;
202202

203-
ALTER TABLE `cloud`.`sync_queue_item` ADD `queue_proc_time` DATETIME NOT NULL COMMENT 'when processing started for the item' AFTER `queue_proc_number`;
203+
ALTER TABLE `cloud`.`sync_queue_item` ADD `queue_proc_time` DATETIME COMMENT 'when processing started for the item' AFTER `queue_proc_number`;
204204

205205
ALTER TABLE `cloud`.`sync_queue_item` ADD INDEX `i_sync_queue__queue_proc_time`(`queue_proc_time`);
206206

0 commit comments

Comments
 (0)