Skip to content

Commit 53650ed

Browse files
vincentbernatsebgoa
authored andcommitted
CLOUDSTACK-7193: handle domain ID being an int
Recent versions of libvirt (at least 0.9.8) will return an int when queried for the ID of a domain, not a string. This breaks some parts of the `security_group.py` script which expects a string containing an int. Notably, this breaks the part handling VM reboots which is therefore not executed. Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch> Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
1 parent 880bff2 commit 53650ed

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

scripts/vm/network/security_group.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -937,7 +937,10 @@ def getvmId(vmName):
937937

938938
conn.close()
939939

940-
return dom.ID()
940+
res = dom.ID()
941+
if isinstance(res, int):
942+
res = str(res)
943+
return res
941944

942945
def getBrfw(brname):
943946
cmd = "iptables-save |grep physdev-is-bridged |grep FORWARD |grep BF |grep '\-o' | grep -w " + brname + "|awk '{print $9}' | head -1"

0 commit comments

Comments
 (0)