CLOUDSTACK-7195: log wide exceptions in security_group.py

vincentbernat · pdion891 · commit 3ea8a1187a82 · 2014-12-05T17:24:27.000-05:00
Some try/except in security_group.py catch a lot of exceptions. There
was already one fixed in CLOUDSTACK-1052. Here is another one. We use
logging.exception() to log those exceptions.

Signed-off-by: Vincent Bernat &lt;Vincent.Bernat@exoscale.ch&gt;
Signed-off-by: Pierre-Luc Dion &lt;pdion891@apache.org&gt;
diff --git a/scripts/vm/network/security_group.py b/scripts/vm/network/security_group.py
@@ -25,7 +25,6 @@
 import xml.dom.minidom
 from optparse import OptionParser, OptionGroup, OptParseError, BadOptionError, OptionError, OptionConflictError, OptionValueError
 import re
-import traceback
 import libvirt
 
 logpath = "/var/run/cloud/"        # FIXME: Logs should reside in /var/log/cloud
@@ -678,7 +677,7 @@ def get_rule_logs_for_vms():
                 log = get_rule_log_for_vm(name)
                 result.append(log)
     except:
-        logging.debug("Failed to get rule logs, better luck next time!")
+        logging.exception("Failed to get rule logs, better luck next time!")
 
     print ";".join(result)
 
@@ -883,8 +882,7 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif
 
     return 'true'
   except:
-    exceptionText = traceback.format_exc()
-    logging.debug("Failed to network rule !: " + exceptionText)
+    logging.exception("Failed to network rule !")
 
 def getVifs(vmName):
     vifs = []
