Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method

rsafonseca · yadvr · commit 1b79a8e1d64c · 2015-06-15T12:24:04.000+03:00
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes apache#447
diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java
@@ -402,8 +402,6 @@ public void setDetails(Map<String, String> details2) {
     }
 
     public String getDetail(String name) {
-        assert (details != null) : "Did you forget to load the details?";
-
         return details != null ? details.get(name) : null;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -402,8 +402,6 @@ public void setDetails(Map<String, String> details2) {`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`public String getDetail(String name) {`
`405`		`- assert (details != null) : "Did you forget to load the details?";`
`406`		`-`
`407`	`405`	`return details != null ? details.get(name) : null;`
`408`	`406`	`}`
`409`	`407`