Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource

rsafonseca · DaanHoogland · commit 039d632ad314 · 2015-06-08T09:40:59.000+02:00
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com> This closes apache#366
diff --git a/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java b/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
@@ -294,7 +294,7 @@ private synchronized Answer execute(IpAssocCommand cmd, int numRetries) {
             for (IpAddressTO ip : ips) {
                 // is it saver to use Long.valueOf(BroadcastDomain.getValue(ip.getBroadcastUri())) ???
                 // i.o.w. can this contain vlan:// then change !!!
-                long guestVlanTag = Long.valueOf(ip.getBroadcastUri());
+                long guestVlanTag = Long.parseLong(ip.getBroadcastUri());
                 // It's a hack, using isOneToOneNat field for indicate if it's inline or not
                 boolean inline = ip.isOneToOneNat();
                 String vlanSelfIp = inline ? tagAddressWithRouteDomain(ip.getVlanGateway(), guestVlanTag) : ip.getVlanGateway();
@@ -700,7 +700,7 @@ private void deleteVirtualServerAndDefaultPool(String virtualServerName) throws
                 List<String> poolMembers = getMembers(virtualServerName);
                 for (String poolMember : poolMembers) {
                     String[] destIpAndPort = getIpAndPort(poolMember);
-                    deletePoolMember(virtualServerName, destIpAndPort[0], Integer.valueOf(destIpAndPort[1]));
+                    deletePoolMember(virtualServerName, destIpAndPort[0], Integer.parseInt(destIpAndPort[1]));
                 }
 
                 // Delete the virtual server
@@ -886,7 +886,7 @@ private void deleteInactivePoolMembers(String virtualServerName, List<String> ac
         for (String member : allPoolMembers) {
             if (!activePoolMembers.contains(member)) {
                 String[] ipAndPort = member.split("-");
-                deletePoolMember(virtualServerName, ipAndPort[0], Integer.valueOf(ipAndPort[1]));
+                deletePoolMember(virtualServerName, ipAndPort[0], Integer.parseInt(ipAndPort[1]));
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ private synchronized Answer execute(IpAssocCommand cmd, int numRetries) {`
`294`	`294`	`for (IpAddressTO ip : ips) {`
`295`	`295`	`// is it saver to use Long.valueOf(BroadcastDomain.getValue(ip.getBroadcastUri())) ???`
`296`	`296`	`// i.o.w. can this contain vlan:// then change !!!`
`297`		`- long guestVlanTag = Long.valueOf(ip.getBroadcastUri());`
	`297`	`+ long guestVlanTag = Long.parseLong(ip.getBroadcastUri());`
`298`	`298`	`// It's a hack, using isOneToOneNat field for indicate if it's inline or not`
`299`	`299`	`boolean inline = ip.isOneToOneNat();`
`300`	`300`	`String vlanSelfIp = inline ? tagAddressWithRouteDomain(ip.getVlanGateway(), guestVlanTag) : ip.getVlanGateway();`
`@@ -700,7 +700,7 @@ private void deleteVirtualServerAndDefaultPool(String virtualServerName) throws`
`700`	`700`	`List<String> poolMembers = getMembers(virtualServerName);`
`701`	`701`	`for (String poolMember : poolMembers) {`
`702`	`702`	`String[] destIpAndPort = getIpAndPort(poolMember);`
`703`		`- deletePoolMember(virtualServerName, destIpAndPort[0], Integer.valueOf(destIpAndPort[1]));`
	`703`	`+ deletePoolMember(virtualServerName, destIpAndPort[0], Integer.parseInt(destIpAndPort[1]));`
`704`	`704`	`}`
`705`	`705`
`706`	`706`	`// Delete the virtual server`
`@@ -886,7 +886,7 @@ private void deleteInactivePoolMembers(String virtualServerName, List<String> ac`
`886`	`886`	`for (String member : allPoolMembers) {`
`887`	`887`	`if (!activePoolMembers.contains(member)) {`
`888`	`888`	`String[] ipAndPort = member.split("-");`
`889`		`- deletePoolMember(virtualServerName, ipAndPort[0], Integer.valueOf(ipAndPort[1]));`
	`889`	`+ deletePoolMember(virtualServerName, ipAndPort[0], Integer.parseInt(ipAndPort[1]));`
`890`	`890`	`}`
`891`	`891`	`}`
`892`	`892`	`}`