Fixed few coverity issues

sedukull · sedukull · commit 023811286e1f · 2014-08-19T22:01:15.000+05:30
Signed-off-by: Santhosh Edukulla &lt;santhosh.edukulla@gmail.com&gt;
diff --git a/utils/src/com/cloud/utils/net/NetUtils.java b/utils/src/com/cloud/utils/net/NetUtils.java
@@ -192,7 +192,10 @@ public static String getDefaultHostIp() {
             }
 
             String[] info = NetUtils.getNetworkParams(nic);
-            return info[0];
+            if (info != null) {
+                return info[0];
+            }
+            return null;
         }
     }
 
@@ -489,7 +492,10 @@ public static boolean isSiteLocalAddress(String ipAddress) {
             return false;
         } else {
             InetAddress ip = parseIpAddress(ipAddress);
-            return ip.isSiteLocalAddress();
+            if(ip != null) {
+                return ip.isSiteLocalAddress();
+            }
+            return false;
         }
     }
 
@@ -1252,16 +1258,21 @@ public static String getIp6FromRange(String ip6Range) {
         while (next.compareTo(gap) >= 0) {
             next = new BigInteger(gap.bitLength(), s_rand);
         }
+        InetAddress resultAddr = null;
         BigInteger startInt = convertIPv6AddressToBigInteger(start);
-        BigInteger resultInt = startInt.add(next);
-        InetAddress resultAddr;
-        try {
-            resultAddr = InetAddress.getByAddress(resultInt.toByteArray());
-        } catch (UnknownHostException e) {
-            return null;
+        if (startInt != null) {
+            BigInteger resultInt = startInt.add(next);
+            try {
+                resultAddr = InetAddress.getByAddress(resultInt.toByteArray());
+            } catch (UnknownHostException e) {
+                return null;
+            }
         }
-        IPv6Address ip = IPv6Address.fromInetAddress(resultAddr);
-        return ip.toString();
+        if( resultAddr != null) {
+            IPv6Address ip = IPv6Address.fromInetAddress(resultAddr);
+            return ip.toString();
+        }
+        return null;
     }
 
     //RFC3315, section 9.4
@@ -1300,8 +1311,10 @@ public static BigInteger countIp6InRange(String ip6Range) {
         }
         BigInteger startInt = convertIPv6AddressToBigInteger(start);
         BigInteger endInt = convertIPv6AddressToBigInteger(end);
-        if (startInt.compareTo(endInt) > 0) {
-            return null;
+        if (endInt != null) {
+            if (startInt.compareTo(endInt) > 0) {
+                return null;
+            }
         }
         return endInt.subtract(startInt).add(BigInteger.ONE);
     }
