Fixing the special case in Buffer.concat

feross · feross · commit 97ecf4c599de · 2015-08-05T10:41:09.000+02:00
See: nodejs/node#1937
diff --git a/index.js b/index.js
@@ -285,8 +285,6 @@ Buffer.concat = function concat (list, length) {
 
   if (list.length === 0) {
     return new Buffer(0)
-  } else if (list.length === 1) {
-    return list[0]
   }
 
   var i
diff --git a/test/methods.js b/test/methods.js
@@ -55,7 +55,7 @@ test('concat() a varying number of buffers', function (t) {
 
   t.equal(flatZero.length, 0)
   t.equal(flatOne.toString(), 'asdf')
-  t.equal(flatOne, one[0])
+  t.deepEqual(flatOne, one[0])
   t.equal(flatLong.toString(), (new Array(10 + 1).join('asdf')))
   t.equal(flatLongLen.toString(), (new Array(10 + 1).join('asdf')))
   t.end()

Original file line number	Diff line number	Diff line change
`@@ -285,8 +285,6 @@ Buffer.concat = function concat (list, length) {`
`285`	`285`
`286`	`286`	`if (list.length === 0) {`
`287`	`287`	`return new Buffer(0)`
`288`		`- } else if (list.length === 1) {`
`289`		`- return list[0]`
`290`	`288`	`}`
`291`	`289`
`292`	`290`	`var i`