From 961c13e759f27e861af6d7aaf57a1cc93991685d Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 14 Jul 2026 14:20:30 -0700 Subject: [PATCH] [dbsp] Don't issue warning for pidlock file. This suppresses a warning of the form ``` INFO dbsp::circuit::checkpointer: Keeping unexpected File { size: 0 } feldera.pidlock ``` when a pipeline restarts. Tested manually by starting a pipeline with nonempty storage with and without this commit. Fixes: https://github.com/feldera/cloud/issues/1726 Signed-off-by: Ben Pfaff --- crates/dbsp/src/circuit/checkpointer.rs | 2 ++ crates/dbsp/src/storage/dirlock.rs | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/dbsp/src/circuit/checkpointer.rs b/crates/dbsp/src/circuit/checkpointer.rs index 04a3a255dba..36f0167d042 100644 --- a/crates/dbsp/src/circuit/checkpointer.rs +++ b/crates/dbsp/src/circuit/checkpointer.rs @@ -1,6 +1,7 @@ //! Logic to manage persistent checkpoints for a circuit. use crate::dynamic::{self, data::DataTyped}; +use crate::storage::dirlock::LockedDirectory; use crate::storage::file::SerializerInner; use crate::{Error, NumEntries, TypedBox}; use enum_map::{Enum, EnumMap}; @@ -120,6 +121,7 @@ impl Checkpointer { in_use_paths.insert(format!("{}.mut", STATUS_FILE).into(), SmallVec::new()); in_use_paths.insert(DATAFUSION_TEMP_DIR.into(), SmallVec::new()); in_use_paths.insert(ACTIVATION_MARKER_FILE.into(), SmallVec::new()); + in_use_paths.insert(LockedDirectory::LOCKFILE_NAME.into(), SmallVec::new()); for (checkpoint_index, cpm) in self.checkpoint_list.iter().enumerate() { in_use_paths .entry(cpm.uuid.to_string().into()) diff --git a/crates/dbsp/src/storage/dirlock.rs b/crates/dbsp/src/storage/dirlock.rs index 16091e4f9db..70a392359ad 100644 --- a/crates/dbsp/src/storage/dirlock.rs +++ b/crates/dbsp/src/storage/dirlock.rs @@ -92,7 +92,7 @@ fn get_lock(file: &File) -> Result, IoError> { } impl LockedDirectory { - const LOCKFILE_NAME: &'static str = "feldera.pidlock"; + pub const LOCKFILE_NAME: &'static str = "feldera.pidlock"; /// Attempts to create a new pidfile in the `base_path` directory, returning /// an error if the file was already created by a different process (and