From b26ee04a66e3b19c6275133dce1a4d5a21b4b4ba Mon Sep 17 00:00:00 2001
From: Karakatiza666 <bulakh.96@gmail.com>
Date: Sun, 14 Jun 2026 09:56:30 +0000
Subject: [PATCH] [profiler] Remove artificial columns 'min' and 'max' from the
 per-worker data

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
---
 js-packages/profiler-lib/src/cytograph.ts | 24 ++++-------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

diff --git a/js-packages/profiler-lib/src/cytograph.ts b/js-packages/profiler-lib/src/cytograph.ts
index 6654901a7c..b0291277b8 100644
--- a/js-packages/profiler-lib/src/cytograph.ts
+++ b/js-packages/profiler-lib/src/cytograph.ts
@@ -3,7 +3,7 @@
 import cytoscape, { type EdgeCollection, type EdgeDefinition, type ElementsDefinition, type EventObject, type NodeDefinition, type NodeSingular, type StylesheetJson } from 'cytoscape';
 import dblclick from 'cytoscape-dblclick';
 import { assert, Graph, OMap, Option, type EncodableAsString, NumericRange, Edge } from './util.js';
-import { CircuitProfile, NodeAndMetric, PropertyValue, MissingValue, type NodeId } from './profile.js';
+import { CircuitProfile, NodeAndMetric, PropertyValue, type NodeId } from './profile.js';
 import { CircuitSelection } from './selection.js';
 import elk from 'cytoscape-elk';
 import { Sources } from './dataflow.js';
@@ -677,9 +677,9 @@ export class CytographRendering {
     /** Compute the attributes for all cytograph nodes based on the circuit profile and current selection. */
     computeAttributes(profile: CircuitProfile, selection: MetadataSelection) {
         let workers = selection.workersVisible.getSelectedElements(profile.getWorkerNames());
-        let columnNames = [...workers.map(w => w.toString())];
-        columnNames.push("Min");
-        columnNames.push("Max");
+        // One column per visible worker. Aggregates such as min/max are not produced here:
+        // consumers that want them compute them from the per-worker values themselves.
+        let columnNames = workers.map(w => w.toString());
         for (const node of this.currentGraph!.nodes) {
             let profileNode = profile.getNode(node.getId()).unwrap();
             let data = new Map<string, Array<SerializedMeasurement>>();
@@ -690,25 +690,9 @@ export class CytographRendering {
                 let metrics = profileNode.getMeasurements(metric);
                 let selected = selection.workersVisible.getSelectedElements(metrics);
                 let measurements: Array<SerializedMeasurement> = [];
-                let min: PropertyValue = MissingValue.INSTANCE;
-                let max: PropertyValue = MissingValue.INSTANCE;
                 for (const m of selected) {
                     measurements.push(CytographRendering.toMeasurement(m, range));
                 }
-                // Compute min and max over all metrics, including the ones not selected
-                for (const m of metrics) {
-                    if (min instanceof MissingValue ||
-                        (m.getNumericValue().isSome() && min.getNumericValue().unwrap() > m.getNumericValue().unwrap())) {
-                        min = m;
-                    }
-                    if (max instanceof MissingValue ||
-                        (m.getNumericValue().isSome() && max.getNumericValue().unwrap() < m.getNumericValue().unwrap())) {
-                        max = m;
-                    }
-                }
-
-                measurements.push(CytographRendering.toMeasurement(min, range));
-                measurements.push(CytographRendering.toMeasurement(max, range));
                 data.set(metric, measurements);
             }
             // additional key-value per node attributes