Update contribution guide#262
Merged
Merged
Conversation
ryzhyk
approved these changes
Jun 20, 2023
| - Push your changes to a topic branch in the repository or a fork if you don't have commit access to (the reason that pushing directly to the repo is preferred is because then CI will be able to add benchmark results to the PR in the comments). | ||
| - Push your changes to a topic branch in the repository (push to your fork if | ||
| you don't have commit access to the dbsp repository --- pushing directly | ||
| to the repo is preferred is because then CI will be able to add benchmark |
|
|
||
| ## Contribution Flow | ||
|
|
||
| ### Forking |
Contributor
There was a problem hiding this comment.
This is kind of redundant, since forking is the standard way to contribute for external contributors, but I'm ok with being verbose.
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reduce verbosity of a demo test