Skip to content

Commit f9fb7d1

Browse files
committed
Fix crash when entering Server tab in connector edit dialog
Signed-off-by: George <bulakh.96@gmail.com>
1 parent dcedb2b commit f9fb7d1

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ RUN ARCH=`dpkg --print-architecture`; \
5555
## Install python dependencies for the demos
5656

5757
RUN \
58-
pip3 install gdown
58+
pip3 install gdown kafka-python
5959

6060
## Switch to non-root user
6161

web-console/src/lib/components/connectors/dialogs/elements/kafka/Common.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const KafkaBootstrapServersElement = (props: { disabled?: boolean; parent
77
multiline
88
transform={{
99
input: (v: string[]) => {
10-
return v.join(', ')
10+
return v?.join(', ')
1111
},
1212
output: (v: string) => {
1313
return v.split(', ')

web-console/src/lib/components/services/dialogs/KafkaService.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ const TabKafkaConfig = (props: { disabled?: boolean }) => {
405405
multiline
406406
transform={{
407407
input: (v: string[]) => {
408-
return v.join(', ')
408+
return v?.join(', ')
409409
},
410410
output: (v: string) => {
411411
return v.split(', ')

web-console/src/lib/functions/kafka/librdkafkaOptions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -975,7 +975,7 @@ const toKafkaOption = (optionName: string, v: LibrdkafkaOptionType, type: Return
975975
.with('boolean', 'number', () => String(v))
976976
.with('list', () => {
977977
invariant(Array.isArray(v), 'librdkafka option ' + optionName + ' ' + v + ' is not an array')
978-
return v.join(', ')
978+
return v?.join(', ')
979979
})
980980
.with('array', () => {
981981
invariant(Array.isArray(v), 'librdkafka option ' + optionName + ' ' + v + ' is not an array')

0 commit comments

Comments
 (0)