[dbsp_adapters] Fix openapi generation

Karakatiza666 · Karakatiza666 · commit f7abdea25a0a · 2026-01-26T16:04:18.000Z
Signed-off-by: Karakatiza666 &lt;bulakh.96@gmail.com&gt;
diff --git a/crates/adapters/src/samply.rs b/crates/adapters/src/samply.rs
@@ -311,8 +311,6 @@ pub(crate) enum SamplyStatus {
 pub(crate) struct SamplyState {
     pub(crate) last_profile: SamplyProfile,
     pub(crate) samply_status: SamplyStatus,
-    /// Cached result of profiling availability check (None = not checked yet)
-    profiling_available: Option<bool>,
 }
 
 impl SamplyState {
diff --git a/crates/feldera-types/src/query_params.rs b/crates/feldera-types/src/query_params.rs
@@ -55,8 +55,9 @@ fn default_samply_profile_duration() -> u64 {
 
 /// Query parameters to retrieve samply profile.
 #[derive(Debug, Deserialize, IntoParams, ToSchema)]
+#[into_params(parameter_in = Query)]
 pub struct SamplyProfileGetParams {
-    /// If true, returns 307 redirect if profile collection is in progress.
+    /// If true, returns 204 redirect with Retry-After header if profile collection is in progress.
     /// If false or not provided, returns the last collected profile.
     #[serde(default)]
     pub latest: bool,
diff --git a/crates/pipeline-manager/src/api/endpoints/pipeline_interaction.rs b/crates/pipeline-manager/src/api/endpoints/pipeline_interaction.rs
@@ -1225,12 +1225,13 @@ pub(crate) async fn start_samply_profile(
         SamplyProfileGetParams,
     ),
     responses(
+        // Note: This endpoint may also return 204 No Content with Retry-After header
+        // when latest=true and profiling is in progress, but progenitor can only handle
+        // one success response type, so it's not documented here.
         (status = OK
-            , description = "Samply profile as a gzip containing the profile that can be inspected by the samply tool"
+            , description = "Samply profile as a gzip containing the profile that can be inspected by the samply tool. Note: may return 204 No Content with Retry-After header if latest=true and profiling is in progress."
             , content_type = "application/gzip"
             , body = Vec<u8>),
-        (status = NO_CONTENT
-            , description = "Samply profile collection is in progress. Check the Retry-After header for expected completion time."),
         (status = NOT_FOUND
             , description = "Pipeline with that name does not exist"
             , body = ErrorResponse
diff --git a/openapi.json b/openapi.json
@@ -4266,17 +4266,17 @@
           },
           {
             "name": "latest",
-            "in": "path",
-            "description": "If true, returns 307 redirect if profile collection is in progress.\nIf false or not provided, returns the last collected profile.",
-            "required": true,
+            "in": "query",
+            "description": "If true, returns 204 redirect with Retry-After header if profile collection is in progress.\nIf false or not provided, returns the last collected profile.",
+            "required": false,
             "schema": {
               "type": "boolean"
             }
           }
         ],
         "responses": {
           "200": {
-            "description": "Samply profile as a gzip containing the profile that can be inspected by the samply tool",
+            "description": "Samply profile as a gzip containing the profile that can be inspected by the samply tool. Note: may return 204 No Content with Retry-After header if latest=true and profiling is in progress.",
             "content": {
               "application/gzip": {
                 "schema": {
@@ -4286,9 +4286,6 @@
               }
             }
           },
-          "204": {
-            "description": "Samply profile collection is in progress. Check the Retry-After header for expected completion time."
-          },
           "400": {
             "description": "No samply profile exists for the pipeline, create one by calling `POST /pipelines/{pipeline_name}/samply_profile?duration_secs=30`",
             "content": {

Original file line number	Diff line number	Diff line change
`@@ -311,8 +311,6 @@ pub(crate) enum SamplyStatus {`
`311`	`311`	`pub(crate) struct SamplyState {`
`312`	`312`	`pub(crate) last_profile: SamplyProfile,`
`313`	`313`	`pub(crate) samply_status: SamplyStatus,`
`314`		`- /// Cached result of profiling availability check (None = not checked yet)`
`315`		`- profiling_available: Option<bool>,`
`316`	`314`	`}`
`317`	`315`
`318`	`316`	`impl SamplyState {`