Skip to content

Commit e15570e

Browse files
committed
[pipeline-manager] Improve build change detection inside profiler-lib
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
1 parent 1ca4ac2 commit e15570e

File tree

7 files changed

+25
-16
lines changed

7 files changed

+25
-16
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
},
3737
"importSorter.generalConfiguration.configurationFilePath": "./import-sorter.json",
3838
"editor.defaultFormatter": "esbenp.prettier-vscode",
39-
"prettier.configPath": "web-console/.prettierrc"
39+
"prettier.configPath": "js-packages/web-console/.prettierrc"
4040
}
4141
}
4242
},

.devcontainer/postCreate.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# Install Playwright system dependencies
2-
cd ./web-console && bunx playwright install-deps
2+
cd ./js-packages/web-console && bunx playwright install-deps
33
# Install Playwright browsers
44
bunx playwright install

.dockerignore

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,14 @@
66
**/__pycache__
77
**/.venv
88
**/.git
9-
web-console/pipeline-manager-*/
10-
web-console/node_modules/
11-
web-console/.svelte-kit/
12-
web-console/tmp/
9+
js-packages/profiler-lib/node_modules/
10+
js-packages/profiler-lib/dist/
11+
js-packages/profiler-app/node_modules/
12+
js-packages/profiler-app/dist/
13+
js-packages/web-console/node_modules/
14+
js-packages/web-console/.svelte-kit/
15+
js-packages/web-console/build/
16+
node_modules/
1317
vite.config.js.timestamp-*
1418
vite.config.ts.timestamp-*
1519
.output

CLAUDE.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9586,7 +9586,15 @@ This script manages all `CLAUDE.md` files in the repository by **merging** them
95869586
- Preserves directory structure when restoring files.
95879587

95889588
### **Usage**
9589-
Run from any subdirectory (e.g., `/web-console`) and optionally pass the repo root path:
9589+
9590+
Run from the repository root through package.json scripts:
9591+
9592+
```bash
9593+
bun run split-claude
9594+
bun run merge-claude
9595+
```
9596+
9597+
Run from any subdirectory by passing the root CLAUDE.md path:
95909598

95919599
```bash
95929600
bun ../scripts/claude.js merge --root ..

crates/pipeline-manager/build.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@ use vergen_gitcl::*;
66

77
// These are touched during the build, so it would re-build every time if we
88
// don't exclude them from change detection:
9-
const EXCLUDE_LIST: [&str; 4] = [
9+
const EXCLUDE_LIST: [&str; 5] = [
1010
"../../js-packages/web-console/node_modules",
1111
"../../js-packages/web-console/build",
1212
"../../js-packages/web-console/.svelte-kit",
13-
"../../js-packages/profiler-lib",
13+
"../../js-packages/profiler-lib/node_modules",
14+
"../../js-packages/profiler-lib/dist",
1415
];
1516

1617
/// The build script has two modes:
@@ -40,9 +41,9 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
4041
EXCLUDE_LIST
4142
.iter()
4243
.any(|exclude| path.to_str().unwrap().starts_with(exclude))
43-
// Also exclude web-console folder itself because we mutate things inside
44-
// of it
44+
// Exclude web-console and profiler-lib dirs themselves because we mutate ignored dirs inside of them
4545
|| path.to_str().unwrap() == "../../js-packages/web-console/"
46+
|| path.to_str().unwrap() == "../../js-packages/profiler-lib/"
4647
})
4748
.path("../../js-packages/web-console/")
4849
.path("../../js-packages/profiler-lib/")

js-packages/web-console/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ sudo curl -fsSL https://bun.sh/install | bash -s "bun-v1.3.3"
2323

2424
# Install OpenAPI typings generator
2525
sudo bun install --global @hey-api/openapi-ts
26-
27-
# Clone the repo for the UI
28-
git clone https://github.com/feldera/feldera.git
29-
cd dbsp/web-console
3026
```
3127

3228
## Development

js-packages/web-console/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"scripts": {
66
"clean-install": "bun ci",
77
"dev": "vite dev --host",
8-
"prebuild": "cd ../profiler-lib && ([ \"$CI\" = \"TRUE\" ] && bun install || true) && bun run build",
8+
"prebuild": "cd ../profiler-lib && bun run build",
99
"build": "svelte-kit sync && svelte-check --threshold error && vite build",
1010
"preview": "vite preview --host",
1111
"check": "svelte-kit sync && svelte-check",

0 commit comments

Comments
 (0)