Disable tracing by default.

Leonid Ryzhyk · gz · commit c0a5a76247c5 · 2024-09-24T04:37:12.000Z
We use jaeger for tracing. The default pipeline configuration had
tracing enabled, the assumption being that it has negligible runtime
cost. However, we've discovered that it can consume gigabytes of RAM
(and I'm not even sure there's an upper bound) presumably buffering
events in memory. We therefore switch the default to false.

Signed-off-by: Leonid Ryzhyk &lt;leonid@feldera.com&gt;
diff --git a/crates/feldera-types/src/config.rs b/crates/feldera-types/src/config.rs
@@ -42,8 +42,10 @@ fn default_tracing_endpoint() -> String {
 }
 
 /// Default value of `RuntimeConfig::tracing`.
+// We discovered that the jaeger crate can use up gigabytes of RAM, so it's not harmless
+// to keep it on by default.
 fn default_tracing() -> bool {
-    true
+    false
 }
 
 /// Pipeline deployment configuration.

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,10 @@ fn default_tracing_endpoint() -> String {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	/// Default value of `RuntimeConfig::tracing`.
	`45`	`+// We discovered that the jaeger crate can use up gigabytes of RAM, so it's not harmless`
	`46`	`+// to keep it on by default.`
`45`	`47`	`fn default_tracing() -> bool {`
`46`		`- true`
	`48`	`+ false`
`47`	`49`	`}`
`48`	`50`
`49`	`51`	`/// Pipeline deployment configuration.`