Skip to content

Commit a50460c

Browse files
committed
[pipeline-manager] Disable stream compression for streaming endpoints
Update tests that involve support_bundle Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
1 parent c2599b5 commit a50460c

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ RUN apt-get update --fix-missing && \
3737
RUN apt-get install -y \
3838
gcc clang libclang-dev python3-pip python3-plumbum \
3939
hub numactl openjdk-21-jre-headless maven
40+
RUN curl -LsSf https://astral.sh/uv/install.sh | sh
4041

4142
## Install nodejs (optional)
4243
RUN mkdir -p /etc/apt/keyrings

crates/pipeline-manager/src/runner/interaction.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,8 @@ impl RunnerInteraction {
540540
for header in response.headers().into_iter() {
541541
builder.append_header(header);
542542
}
543+
// Disable compression to avoid gzip frame buffering that causes clients to block
544+
builder.insert_header(actix_http::ContentEncoding::Identity);
543545
Ok(builder.streaming(response))
544546
}
545547

@@ -612,6 +614,8 @@ impl RunnerInteraction {
612614
for header in response.headers().into_iter() {
613615
builder.append_header(header);
614616
}
617+
// Disable compression to avoid gzip frame buffering that causes clients to block
618+
builder.insert_header(actix_http::ContentEncoding::Identity);
615619
Ok(builder.streaming(response))
616620
}
617621

python/feldera/pipeline.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1337,6 +1337,7 @@ def support_bundle(
13371337
stats: bool = True,
13381338
pipeline_config: bool = True,
13391339
system_config: bool = True,
1340+
dataflow_graph: bool = True,
13401341
) -> bytes:
13411342
"""
13421343
Generate a support bundle containing diagnostic information from this pipeline.
@@ -1354,6 +1355,7 @@ def support_bundle(
13541355
:param stats: Whether to collect stats data (default: True)
13551356
:param pipeline_config: Whether to collect pipeline configuration data (default: True)
13561357
:param system_config: Whether to collect system configuration data (default: True)
1358+
:param dataflow_graph: Whether to collect dataflow graph (default: True)
13571359
:return: The support bundle as bytes (ZIP archive)
13581360
:raises FelderaAPIError: If the pipeline does not exist or if there's an error
13591361
"""
@@ -1374,6 +1376,8 @@ def support_bundle(
13741376
params["pipeline_config"] = "false"
13751377
if not system_config:
13761378
params["system_config"] = "false"
1379+
if not dataflow_graph:
1380+
params["dataflow_graph"] = "false"
13771381

13781382
support_bundle_bytes = self.client.get_pipeline_support_bundle(
13791383
self.name, params=params

python/tests/platform/test_shared_pipeline.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ def test_support_bundle(self):
653653
with zipfile.ZipFile(io.BytesIO(support_bundle_bytes), "r") as zip_file:
654654
# Check that the ZIP file contains some files
655655
file_list = zip_file.namelist()
656-
assert any("json_circuit_profile.zip" in item for item in file_list)
656+
assert any("circuit_profile.json" in item for item in file_list)
657657
assert len(file_list) > 0
658658
except zipfile.BadZipFile:
659659
self.fail("Support bundle is not a valid ZIP file")
@@ -688,6 +688,7 @@ def test_support_bundle_with_selectors(self):
688688
stats=False,
689689
pipeline_config=False,
690690
system_config=False,
691+
dataflow_graph=False,
691692
)
692693

693694
assert isinstance(support_bundle_bytes, bytes)

0 commit comments

Comments
 (0)