dbsp: Fix FileWSet negation.

gz · gz · commit a4bce2e0ec07 · 2026-03-30T17:33:36.000-07:00
We didn't load the weight into cursor.diff which caused
some newly written tests to fail

We did an anlaysis and concluded that this method,
while wrong, luckily wasn't used anywhere relevant in real
circuits.

Signed-off-by: Gerd Zellweger &lt;mail@gerdzellweger.com&gt;
diff --git a/crates/dbsp/src/trace/ord/file/wset_batch.rs b/crates/dbsp/src/trace/ord/file/wset_batch.rs
@@ -269,7 +269,7 @@ where
 
         let mut cursor = self.cursor();
         while cursor.key_valid() {
-            let diff = cursor.diff.neg_by_ref();
+            let diff = cursor.weight().neg_by_ref();
             writer.write0((cursor.key(), diff.erase())).unwrap_storage();
             cursor.step_key();
         }

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ where`
`269`	`269`
`270`	`270`	`let mut cursor = self.cursor();`
`271`	`271`	`while cursor.key_valid() {`
`272`		`- let diff = cursor.diff.neg_by_ref();`
	`272`	`+ let diff = cursor.weight().neg_by_ref();`
`273`	`273`	`writer.write0((cursor.key(), diff.erase())).unwrap_storage();`
`274`	`274`	`cursor.step_key();`
`275`	`275`	`}`