Fix issues found by pre-commit

mihaibudiu · gz · commit a065bf89d14b · 2026-03-10T00:18:25.000Z
Signed-off-by: Mihai Budiu &lt;mbudiu@feldera.com&gt;
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -8,7 +8,7 @@ repos:
       - id: cargo-clippy
         name: Clippy Automatic Fixes
         description: Run the Clippy linter on the package.
-        entry: cargo clippy --fix
+        entry: cargo clippy --fix --allow-dirty
         language: rust
         files: \.rs$
         pass_filenames: false
diff --git a/crates/adapterlib/src/format.rs b/crates/adapterlib/src/format.rs
@@ -248,7 +248,7 @@ impl InputBuffer for Vec<Box<dyn InputBuffer>> {
         // Index of first buffer that should be preserved
         let mut index = 0;
         for v in self.iter_mut() {
-            if remaining <= 0 {
+            if remaining == 0 {
                 break;
             }
             let buf = v.take_some(remaining);
@@ -395,15 +395,11 @@ impl Parser for StreamingPreprocessedParser {
         let (pre_data, mut pre_errors) = self.preprocessor.process(data);
         self.stream_splitter.append(&pre_data);
         let mut parsed: Vec<Box<dyn InputBuffer>> = Vec::new();
-        loop {
-            if let Some(chunk) = self.stream_splitter.next(true) {
-                let (parsed_data, mut parse_errors) = self.parser.parse(chunk, metadata.clone());
-                pre_errors.append(&mut parse_errors);
-                if let Some(data) = parsed_data {
-                    parsed.push(data);
-                }
-            } else {
-                break;
+        while let Some(chunk) = self.stream_splitter.next(true) {
+            let (parsed_data, mut parse_errors) = self.parser.parse(chunk, metadata.clone());
+            pre_errors.append(&mut parse_errors);
+            if let Some(data) = parsed_data {
+                parsed.push(data);
             }
         }
         if parsed.is_empty() {
diff --git a/crates/adapterlib/src/metrics.rs b/crates/adapterlib/src/metrics.rs
@@ -18,9 +18,9 @@ impl ValueType {
 
 /// Connector-specific metrics exported via the Prometheus `/metrics` endpoint.
 ///
-/// Connectors that have metrics beyond the standard [`InputEndpointMetrics`]
+/// Connectors that have metrics beyond the standard `InputEndpointMetrics`
 /// should implement this trait and register themselves via
-/// [`InputConsumer::set_custom_metrics`] during [`TransportInputEndpoint::open`].
+/// `InputConsumer::set_custom_metrics` during `TransportInputEndpoint::open`.
 pub trait ConnectorMetrics: Send + Sync {
     /// Return a list of `(name, help, value_type, value)` tuples.
     ///
diff --git a/crates/adapters/src/controller.rs b/crates/adapters/src/controller.rs
@@ -6195,7 +6195,7 @@ impl ControllerInner {
 
     /// Update counters after receiving a new input batch.
     ///
-    /// See [ControllerStatus::input_batch].
+    /// See `ControllerStatus::input_batch`.
     pub fn input_batch(&self, endpoint_id: Option<EndpointId>, amt: BufferSize) {
         // We update the individual endpoint metrics, then the global metrics.
         // The order is important because global metrics updates can unpark the
diff --git a/crates/adapters/src/integrated/postgres/output.rs b/crates/adapters/src/integrated/postgres/output.rs
@@ -550,7 +550,7 @@ struct WorkerHandle {
     thread: Option<std::thread::JoinHandle<()>>,
 }
 
-/// Coordinates N parallel [`PostgresWorker`]s, each on its own thread.
+/// Coordinates N parallel `PostgresWorker`s, each on its own thread.
 ///
 /// Incoming batches are partitioned by key range so each worker handles
 /// a disjoint slice of the data.
diff --git a/crates/adapters/src/preprocess.rs b/crates/adapters/src/preprocess.rs
@@ -59,7 +59,7 @@ struct DecryptionPreprocessorConfig {
 /// A preprocessor that decrypts each chunk of data using AES-256-GCM.
 ///
 /// The transport delivers the entire encrypted blob in a single [Preprocessor::process]
-/// call (enforced by [WholeBlobSplitter]).  The blob format is:
+/// call (enforced by [`SpongeSplitter`]).  The blob format is:
 ///
 /// ```text
 /// [ 12-byte nonce ][ ciphertext ][ 16-byte GCM authentication tag ]
diff --git a/python/tests/runtime/test_connector_status.py b/python/tests/runtime/test_connector_status.py
@@ -288,7 +288,7 @@ def output_connector_status() -> OutputConnectorStatus:
         assert len(input_status.parse_errors) == 100
         assert input_status.metrics.num_parse_errors == 500
         assert input_status.metrics.num_transport_errors == 0
-        assert input_status.metrics.end_of_input == False
+        assert not input_status.metrics.end_of_input
         assert input_status.fatal_error is None
         assert input_status.metrics.total_records == 500
 

Original file line number	Diff line number	Diff line change
`@@ -550,7 +550,7 @@ struct WorkerHandle {`
`550`	`550`	`thread: Option<std::thread::JoinHandle<()>>,`
`551`	`551`	`}`
`552`	`552`
`553`		-/// Coordinates N parallel [`PostgresWorker`]s, each on its own thread.
	`553`	+/// Coordinates N parallel `PostgresWorker`s, each on its own thread.
`554`	`554`	`///`
`555`	`555`	`/// Incoming batches are partitioned by key range so each worker handles`
`556`	`556`	`/// a disjoint slice of the data.`