[profiler-lib] Determine root node id dynamically instead of assuming it's matches the hard-coded constant

Karakatiza666 · Karakatiza666 · commit 762ef220c551 · 2026-06-16T17:57:57.000Z
Signed-off-by: Karakatiza666 &lt;bulakh.96@gmail.com&gt;
diff --git a/js-packages/profiler-layout/src/lib/components/MetricsView.svelte b/js-packages/profiler-layout/src/lib/components/MetricsView.svelte
@@ -1,5 +1,5 @@
 <script lang="ts" module>
-  import { type NodeAttributes, TOP_NODE_ID } from 'profiler-lib'
+  import type { NodeAttributes } from 'profiler-lib'
 
   export type MetricsMode = 'overview' | 'node' | 'top-nodes'
 
@@ -10,9 +10,13 @@
   ]
 
   /** The toplevel node represents the whole circuit (the overview) rather than a single operator.
-   *  Reused wherever we need to distinguish overview data from a single node. */
-  export function isOverviewAttributes(nodeAttributes: NodeAttributes): boolean {
-    return nodeAttributes.nodeId === TOP_NODE_ID
+   *  `rootNodeId` is the loaded profile's actual toplevel id; while it is `undefined` (no profile
+   *  yet) nothing counts as the overview. */
+  export function isOverviewAttributes(
+    nodeAttributes: NodeAttributes,
+    rootNodeId: string | undefined
+  ): boolean {
+    return rootNodeId !== undefined && nodeAttributes.nodeId === rootNodeId
   }
 
   /** The node id is what `search()` matches against, so it's the query that links back to the
@@ -31,6 +35,8 @@
   interface Props {
     mode: MetricsMode
     tooltipData: TooltipData | null
+    /** The loaded profile's toplevel node id, used to recognise overview data. */
+    rootNodeId: string | undefined
     /** When true, metrics flagged `advanced` in the profile metadata are included. */
     showAdvanced: boolean
     /** Lookup coordinator; the view registers an imperative handler so each Enter on the
@@ -41,13 +47,15 @@
     onSearchNode?: (query: string) => void
   }
 
-  const { mode, tooltipData, showAdvanced, lookup, onSearchNode }: Props = $props()
+  const { mode, tooltipData, rootNodeId, showAdvanced, lookup, onSearchNode }: Props = $props()
 
   const nodeAttributes = $derived(
     tooltipData && 'nodeAttributes' in tooltipData ? tooltipData.nodeAttributes : null
   )
   // Single-node data (a specific operator) as opposed to the whole-circuit overview.
-  const isNodeView = $derived(nodeAttributes ? !isOverviewAttributes(nodeAttributes) : false)
+  const isNodeView = $derived(
+    nodeAttributes ? !isOverviewAttributes(nodeAttributes, rootNodeId) : false
+  )
   const identityRows = $derived(
     nodeAttributes && isNodeView
       ? idAttributes.flatMap((r) => {
diff --git a/js-packages/profiler-layout/src/lib/components/SupportBundleViewerLayout.svelte b/js-packages/profiler-layout/src/lib/components/SupportBundleViewerLayout.svelte
@@ -73,6 +73,8 @@
   }: Props = $props()
 
   let profilerDiagram: ProfilerDiagram | undefined = $state()
+  // The loaded profile's toplevel node id, so the analysis panel can recognise overview data.
+  const diagramRootNodeId = $derived(profilerDiagram?.getProfile()?.rootNodeId)
   let tooltipData: TooltipData | null = $state(null)
   // Most recently inspected operator; the "Node" segment restores it via `setMetricsMode('node')`.
   let lastNodeData: NodeAttributes | null = $state(null)
@@ -258,6 +260,7 @@
   const analysisTabProps = $derived<AnalysisTabProps>({
     metricsMode,
     tooltipData,
+    rootNodeId: diagramRootNodeId,
     showAdvancedMetrics,
     lookup,
     logText,
diff --git a/js-packages/profiler-layout/src/lib/components/tabs/MetricsTab.svelte b/js-packages/profiler-layout/src/lib/components/tabs/MetricsTab.svelte
@@ -9,6 +9,9 @@
   export type AnalysisTabProps = {
     metricsMode: MetricsMode
     tooltipData: TooltipData | null
+    /** Id of the loaded profile's toplevel node, so the Metrics view can tell the overview from a
+     *  single operator. `undefined` until a profile is loaded. */
+    rootNodeId: string | undefined
     /** When true, metrics flagged `advanced` in the profile metadata are shown too. */
     showAdvancedMetrics: boolean
     lookup: LookupCoordinator
@@ -30,6 +33,7 @@
   let {
     metricsMode,
     tooltipData,
+    rootNodeId,
     showAdvancedMetrics,
     lookup,
     onSearchNode
@@ -39,6 +43,7 @@
 <MetricsView
   mode={metricsMode}
   {tooltipData}
+  {rootNodeId}
   showAdvanced={showAdvancedMetrics}
   {lookup}
   {onSearchNode}
diff --git a/js-packages/profiler-lib/src/index.ts b/js-packages/profiler-lib/src/index.ts
@@ -19,7 +19,6 @@ export {
     CircuitProfile,
     PropertyValue,
     MissingValue,
-    TOP_NODE_ID,
     type JsonProfiles
 } from './profile.js';
 export { type Dataflow, type SourcePositionRange } from './dataflow.js';
diff --git a/js-packages/profiler-lib/src/profile.test.ts b/js-packages/profiler-lib/src/profile.test.ts
@@ -2,6 +2,7 @@ import { describe, expect, it } from 'vitest'
 import {
     BooleanValue,
     BytesValue,
+    CircuitProfile,
     CountValue,
     MissingValue,
     PercentValue,
@@ -10,6 +11,22 @@ import {
     TimeValue
 } from './profile.js'
 
+describe('CircuitProfile.isTop', () => {
+    it('recognises the toplevel node by the parsed root id', () => {
+        const profile = new CircuitProfile(1, 'n')
+        expect(profile.isTop('n')).toBe(true)
+        expect(profile.isTop('n0')).toBe(false)
+        expect(profile.isTop('42')).toBe(false)
+    })
+
+    it('does not assume the root id is "n"', () => {
+        // The format conventionally emits "n", but isTop must follow whatever the profile carries.
+        const profile = new CircuitProfile(1, 'root-7')
+        expect(profile.isTop('root-7')).toBe(true)
+        expect(profile.isTop('n')).toBe(false)
+    })
+})
+
 describe('CountValue', () => {
     it('toString formats whole numbers with K/M/B suffixes', () => {
         expect(new CountValue(0).toString()).toBe('0')
diff --git a/js-packages/profiler-lib/src/profile.ts b/js-packages/profiler-lib/src/profile.ts
@@ -6,11 +6,6 @@ import { type MirNode, SourcePositionRanges, SourcePositionRange, Sources, type
 type JsonMeasurement = Array<any>;
 export type NodeId = string;
 
-/** Id of the toplevel profile graph node. Every profile graph is a single node containing the
- *  whole circuit; its metrics are the circuit-wide overview rather than one operator's. The id is
- *  fixed by the profile format. */
-export const TOP_NODE_ID: NodeId = "n";
-
 export type CircuitMetricCategory = string;
 
 export interface ProfileMetricDescription {
@@ -1336,7 +1331,7 @@ export class CircuitProfile {
      * Profile graphs are always a single node containing everything else inside.
      * That node is pretty much ignored everywhere else in this code after parsing. */
     isTop(node: NodeId): boolean {
-        return node === TOP_NODE_ID;
+        return node === this.rootNodeId;
     }
 
     addNode(n: JsonSimpleNodeWrapper | JsonClusterWrapper, parent: Option<NodeId>) {
@@ -1534,7 +1529,9 @@ export class CircuitProfile {
         return Option.some(ranges[0]!);
     }
 
-    constructor(readonly worker_count: number) { }
+    /** @param rootNodeId Id of the toplevel graph node, taken from the parsed profile rather than
+     *  assumed, so {@link isTop} stays correct whatever id the format emits. */
+    constructor(readonly worker_count: number, readonly rootNodeId: NodeId) { }
 
     // Scan the nodes and compute the range of each property
     computePropertyRanges() {
@@ -1607,7 +1604,7 @@ export class CircuitProfile {
         // Decode the graph structure and create the nodes.
         // The graph itself is always a complex node.
         let rootNodeId = json.graph.nodes.id;
-        let result = new CircuitProfile(worker_count);
+        let result = new CircuitProfile(worker_count, rootNodeId);
         result.complexNodes.set(rootNodeId,
             new ComplexNode(rootNodeId, json.graph.nodes.label, worker_count));
         for (const nodeWrapper of json.graph.nodes.nodes) {
