[SQL] Do not take references of expressions in LazyCell initializers

mihaibudiu · gz · commit 709ab9c1af4a · 2026-03-24T03:31:09.000Z
Signed-off-by: Mihai Budiu &lt;mbudiu@feldera.com&gt;
diff --git a/sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/backend/rust/ToRustInnerVisitor.java b/sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/backend/rust/ToRustInnerVisitor.java
@@ -2265,7 +2265,7 @@ public VisitDecision preorder(DBSPFieldExpression expression) {
                         // We are explicitly taking a reference for these cases
                         avoidRef = true;
                 }
-            } else if (parent.is(DBSPBorrowExpression.class)) {
+            } else if (parent.is(DBSPBorrowExpression.class) || parent.is(DBSPLazyExpression.class)) {
                 // Pattern appearing in aggregation
                 avoidRef = true;
             }
diff --git a/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression2Tests.java b/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression2Tests.java
@@ -806,4 +806,21 @@ CREATE TABLE purchase (
                     SUM(value) OVER (ORDER BY ts ROWS BETWEEN 2 PRECEDING AND CURRENT ROW) AS rolling_sum
                     FROM purchase;""", "Not yet implemented: Window aggregates with ROWS");
     }
+
+    @Test
+    public void jsonTests() {
+        this.getCCS("""
+                CREATE TYPE c_t AS ("value" VARCHAR);
+                CREATE TYPE b_t AS ("x" c_t, "y" c_t);
+                CREATE TYPE a_t AS ("b" b_t);
+                CREATE FUNCTION jsonstring_as_a_t(input VARCHAR) RETURNS a_t;
+                
+                CREATE TABLE src ("data" VARCHAR);
+                
+                CREATE VIEW v AS
+                SELECT
+                    jsonstring_as_a_t("data")."b"."x"."value" AS "x_val",
+                    jsonstring_as_a_t("data")."b"."y"."value" AS "y_val"
+                FROM src;""");
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -2265,7 +2265,7 @@ public VisitDecision preorder(DBSPFieldExpression expression) {`
`2265`	`2265`	`// We are explicitly taking a reference for these cases`
`2266`	`2266`	`avoidRef = true;`
`2267`	`2267`	`}`
`2268`		`- } else if (parent.is(DBSPBorrowExpression.class)) {`
	`2268`	`+ } else if (parent.is(DBSPBorrowExpression.class) \|\| parent.is(DBSPLazyExpression.class)) {`
`2269`	`2269`	`// Pattern appearing in aggregation`
`2270`	`2270`	`avoidRef = true;`
`2271`	`2271`	`}`