Skip to content

Commit 687c8d5

Browse files
rivudhkrivudhk
committed
py: add modifications to illegal argument tests
Signed-off-by: rivudhk <rivudhkr@gmail.com> # Conflicts: # python/tests/runtime_aggtest/illarg_tests/test_date_time_fn.py
1 parent 23a2a5d commit 687c8d5

1 file changed

Lines changed: 37 additions & 47 deletions

File tree

‎python/tests/runtime_aggtest/illarg_tests/test_date_time_fn.py‎

Lines changed: 37 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ def __init__(self):
461461
WHERE id = 0"""
462462

463463

464-
# TIMESTAMPDIFF : contains bug: https://github.com/feldera/feldera/issues/4650
464+
# TIMESTAMPDIFF
465465
class illarg_tsdiff_ts_legal(TstView):
466466
def __init__(self):
467467
# checked manually
@@ -486,30 +486,28 @@ def __init__(self):
486486
WHERE id = 0"""
487487

488488

489-
# class illarg_tsdiff_ts1_legal(TstView):
490-
# def __init__(self):
491-
# # checked manually
492-
# self.data = [
493-
# {
494-
# "yr": 1,
495-
# "mth": 19,
496-
# "day": 580,
497-
# "doy": 580,
498-
# "dow": 580,
499-
# "hr": 13926,
500-
# "min": 835560,
501-
# "sec": 50133659,
502-
# }
503-
# ]
504-
# self.sql = """CREATE MATERIALIZED VIEW tsdiff_ts1_legal AS SELECT
505-
# TIMESTAMPDIFF(YEAR, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS yr,
506-
# TIMESTAMPDIFF(MONTH, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS mth,
507-
# TIMESTAMPDIFF(DAY, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS day,
508-
# TIMESTAMPDIFF(HOUR, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS hr,
509-
# TIMESTAMPDIFF(MINUTE, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS min,
510-
# TIMESTAMPDIFF(SECOND, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS sec
511-
# FROM illegal_tbl
512-
# WHERE id = 0"""
489+
class illarg_tsdiff_ts1_legal(TstView):
490+
def __init__(self):
491+
# checked manually
492+
self.data = [
493+
{
494+
"yr": 1,
495+
"mth": 19,
496+
"day": 580,
497+
"hr": 13926,
498+
"min": 835561,
499+
"sec": 50133660,
500+
}
501+
]
502+
self.sql = """CREATE MATERIALIZED VIEW tsdiff_ts1_legal AS SELECT
503+
TIMESTAMPDIFF(YEAR, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS yr,
504+
TIMESTAMPDIFF(MONTH, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS mth,
505+
TIMESTAMPDIFF(DAY, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS day,
506+
TIMESTAMPDIFF(HOUR, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS hr,
507+
TIMESTAMPDIFF(MINUTE, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS min,
508+
TIMESTAMPDIFF(SECOND, '2020-06-21 14:23:44.123'::TIMESTAMP, '2022-01-22 20:24:44.332'::TIMESTAMP) AS sec
509+
FROM illegal_tbl
510+
WHERE id = 0"""
513511

514512

515513
class illarg_tsdiff_datee_legal(TstView):
@@ -576,11 +574,21 @@ def __init__(self):
576574
WHERE id = 0"""
577575

578576

579-
# Ignore: https://github.com/feldera/feldera/issues/4652
580-
class ignore_tsadd_ts1_legal(TstView):
577+
class illarg_tsadd_ts1_legal(TstView):
581578
def __init__(self):
582579
# checked manually
583-
self.data = []
580+
self.data = [
581+
{
582+
"yr": "2022-06-21T14:23:44.123",
583+
"mth": "2020-08-21T14:23:44.123",
584+
"day": "2020-06-23T14:23:44.123",
585+
"hr": "2020-06-21T16:23:44.123",
586+
"min": "2020-06-21T14:25:44.123",
587+
"sec": "2020-06-21T14:23:46.123",
588+
"millisec": "2020-06-21T14:23:44.125",
589+
"microsec": "2020-06-21T14:23:44.123",
590+
}
591+
]
584592
self.sql = """CREATE MATERIALIZED VIEW tsadd_ts1_legal AS SELECT
585593
TIMESTAMPADD(YEAR, 2, '2020-06-21 14:23:44.123'::TIMESTAMP) AS yr,
586594
TIMESTAMPADD(MONTH, 2, '2020-06-21 14:23:44.123'::TIMESTAMP) AS mth,
@@ -594,28 +602,10 @@ def __init__(self):
594602
WHERE id = 0"""
595603

596604

597-
# Ignore: https://github.com/feldera/feldera/issues/4651
598-
class ignore_v(TstView):
599-
def __init__(self):
600-
# checked manually
601-
self.data = []
602-
self.sql = """CREATE MATERIALIZED VIEW v AS SELECT
603-
TIMESTAMPADD(DOY, 2, '2020-06-21 14:23:44.123'::TIMESTAMP) AS doy,
604-
TIMESTAMPADD(DOW, 2, '2020-06-21 14:23:44.123'::TIMESTAMP) AS dow
605-
FROM illegal_tbl
606-
WHERE id = 0"""
607-
608-
609605
class illarg_tsadd_datee_legal(TstView):
610606
def __init__(self):
611607
# checked manually
612-
self.data = [
613-
{
614-
"yr": "2022-06-21",
615-
"mth": "2020-08-21",
616-
"day": "2020-06-23",
617-
}
618-
]
608+
self.data = [{"yr": "2022-06-21", "mth": "2020-08-21", "day": "2020-06-23"}]
619609
self.sql = """CREATE MATERIALIZED VIEW tsadd_datee_legal AS SELECT
620610
TIMESTAMPADD(YEAR, 2, datee) AS yr,
621611
TIMESTAMPADD(MONTH, 2, datee) AS mth,

0 commit comments

Comments
 (0)