[fxp] Add tests that cover special cases in Fixed::checked_div_generic.

blp · blp · commit 5ffd9a4e6aef · 2026-03-28T17:13:33.000Z
These tests guard against regression for the fix in commit 0e3bc33 ("[SQLLIB] Fix bug in DECIMAL division"). Signed-off-by: Ben Pfaff <blp@feldera.com>
diff --git a/crates/fxp/src/fixed.rs b/crates/fxp/src/fixed.rs
@@ -1507,8 +1507,7 @@ mod test {
 
     #[test]
     fn div_generic() {
-        for a in -999..=999 {
-            let af: Fixed<10, 2> = Fixed(a);
+        fn test<const P: usize, const S: usize>(a: i128, af: Fixed<P, S>) {
             for b in -999..=999 {
                 if b != 0 {
                     let bf: Fixed<10, 3> = Fixed(b);
@@ -1521,6 +1520,13 @@ mod test {
                 }
             }
         }
+
+        for a in -999..=999 {
+            let af: Fixed<10, 2> = Fixed(a);
+            test(a, af);
+            let af2: Fixed<18, 10> = af.convert().unwrap();
+            test(a, af2);
+        }
     }
 
     #[test]

Original file line number	Diff line number	Diff line change
`@@ -1507,8 +1507,7 @@ mod test {`
`1507`	`1507`
`1508`	`1508`	`#[test]`
`1509`	`1509`	`fn div_generic() {`
`1510`		`- for a in -999..=999 {`
`1511`		`- let af: Fixed<10, 2> = Fixed(a);`
	`1510`	`+ fn test<const P: usize, const S: usize>(a: i128, af: Fixed<P, S>) {`
`1512`	`1511`	`for b in -999..=999 {`
`1513`	`1512`	`if b != 0 {`
`1514`	`1513`	`let bf: Fixed<10, 3> = Fixed(b);`
`@@ -1521,6 +1520,13 @@ mod test {`
`1521`	`1520`	`}`
`1522`	`1521`	`}`
`1523`	`1522`	`}`
	`1523`	`+`
	`1524`	`+ for a in -999..=999 {`
	`1525`	`+ let af: Fixed<10, 2> = Fixed(a);`
	`1526`	`+ test(a, af);`
	`1527`	`+ let af2: Fixed<18, 10> = af.convert().unwrap();`
	`1528`	`+ test(a, af2);`
	`1529`	`+ }`
`1524`	`1530`	`}`
`1525`	`1531`
`1526`	`1532`	`#[test]`