fix s2_output buffer size limit to respect S2 1MB per-record constraint

Mrhs121 · Mrhs121 · commit 5fbbc8ae574c · 2026-03-12T21:55:20.000+08:00
diff --git a/crates/adapters/src/transport/s2/output.rs b/crates/adapters/src/transport/s2/output.rs
@@ -92,7 +92,9 @@ impl OutputEndpoint for S2OutputEndpoint {
     }
 
     fn max_buffer_size_bytes(&self) -> usize {
-        usize::MAX
+        // S2 enforces a 1MB limit per AppendRecord.
+        // Use a conservative limit to leave room for framing overhead.
+        1_000_000
     }
 
     fn push_buffer(&mut self, buffer: &[u8]) -> AnyResult<()> {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,9 @@ impl OutputEndpoint for S2OutputEndpoint {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`fn max_buffer_size_bytes(&self) -> usize {`
`95`		`- usize::MAX`
	`95`	`+ // S2 enforces a 1MB limit per AppendRecord.`
	`96`	`+ // Use a conservative limit to leave room for framing overhead.`
	`97`	`+ 1_000_000`
`96`	`98`	`}`
`97`	`99`
`98`	`100`	`fn push_buffer(&mut self, buffer: &[u8]) -> AnyResult<()> {`