Docker: add libclang

mihaibudiu · mihaibudiu · commit 50d4888aae8d · 2025-05-23T17:34:25.000Z
Signed-off-by: Mihai Budiu &lt;mbudiu@feldera.com&gt;
diff --git a/.github/workflows/build-java.yml b/.github/workflows/build-java.yml
@@ -8,7 +8,7 @@ jobs:
     name: Build Compiler
     runs-on: [self-hosted, skylake40]
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu
     steps:
       - name: Checkout repository
diff --git a/.github/workflows/build-rust.yml b/.github/workflows/build-rust.yml
@@ -29,7 +29,7 @@ jobs:
     runs-on: ${{ matrix.runner }}
 
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu --privileged
       volumes:
         - /sccache:/sccache
diff --git a/.github/workflows/ci-post-release.yml b/.github/workflows/ci-post-release.yml
@@ -20,7 +20,7 @@ jobs:
   adjust-versions:
     runs-on: [self-hosted, skylake40]
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu
       volumes:
         - /sccache:/sccache
diff --git a/.github/workflows/publish-crates.yml b/.github/workflows/publish-crates.yml
@@ -11,7 +11,7 @@ jobs:
   deploy:
     runs-on: [self-hosted, skylake40]
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu
       volumes:
         - /sccache:/sccache
diff --git a/.github/workflows/test-integration.yml b/.github/workflows/test-integration.yml
@@ -19,8 +19,7 @@ jobs:
     runs-on: ${{ matrix.runner }}
 
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
-
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
     services:
       pipeline-manager:
         image: ${{ vars.FELDERA_IMAGE_NAME }}:sha-${{ github.sha }}
diff --git a/.github/workflows/test-java-nightly.yml b/.github/workflows/test-java-nightly.yml
@@ -19,7 +19,7 @@ jobs:
     runs-on: ${{ matrix.runner }}
 
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu
     steps:
       - name: Checkout repository
diff --git a/.github/workflows/test-java.yml b/.github/workflows/test-java.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ${{ matrix.runner }}
 
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu
     steps:
       - name: Checkout repository
diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml
@@ -22,7 +22,7 @@ jobs:
     runs-on: ${{ matrix.runner }}
 
     container:
-      image: ghcr.io/feldera/feldera-dev:f4797ad926773a38483275405728a9eb3b9005b5
+      image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
       options: --user=ubuntu
 
     steps:
diff --git a/crates/adapters/src/format/avro/serializer.rs b/crates/adapters/src/format/avro/serializer.rs
@@ -608,11 +608,11 @@ impl<'a> Serializer for AvroSchemaSerializer<'a> {
 
                 let mantissa = rounded_decimal.mantissa();
                 match mantissa {
-                    Ok(value) => Ok(AvroValue::Decimal(value.to_be_bytes())),
-                    Err(e) => AvroSerializerError::custom(format!(
+                    Ok(value) => Ok(AvroValue::Decimal(Decimal::from(value.to_be_bytes()))),
+                    Err(e) => Err(AvroSerializerError::custom(format!(
                         "Error converting DECIMAL value {} to Avro: {}",
-                        value, e
-                    )),
+                        v, e
+                    ))),
                 }
             }
             _ => Err(AvroSerializerError::incompatible("string", schema)),
diff --git a/deploy/Dockerfile b/deploy/Dockerfile
@@ -13,6 +13,8 @@ ARG TARGETARCH
 ENV OPENSSL_NO_VENDOR=1
 ENV OPENSSL_STATIC=1
 RUN apt update --fix-missing && apt install \
+  # bindgen needs this (at least the dec crate uses bindgen)
+  libclang-dev \
   # pkg-config is required for cargo to find libssl
   libssl-dev pkg-config \
   cmake \
diff --git a/deploy/README.md b/deploy/README.md
@@ -88,3 +88,66 @@ All commands below should be run from the root directory of the repository.
                  -f deploy/docker-compose-extra.yml \
                  --profile postgres --profile kafka-connect up --build
   ```
+
+# How to add a new package to the Docker images
+
+Let's say you discover that a new dependency (that can be installed
+using `apt-get`) is needed for Feldera.  Here's what you have to do to
+get it included:
+
+1. Edit `build.Dockerfile` and `Dockerfile` in this directory and add
+  the dependency to the list of dependencies; add a comment explaining
+  why it is needed.
+
+  Note that the these Dockerfiles serve slightly different use-cases
+  depending on what you're trying to do: `build.Dockerfile` is used to
+  create a uniform CI environment to build the binaries we run (e.g.,
+  pipeline manager, fda etc.). `Dockerfile` is used to create the
+  _runtime_ image that users of feldera download and execute (it runs
+  the pipeline manager and compiles pipelines). Most of the
+  dependencies will need to be in both files, given the fact that we
+  also run tests in the environment of `build.Dockerfile`, but in rare
+  cases it can happen that a dependency or system tool would only need
+  to be in one of the files.
+
+2. Create a PR with this change, and submit it to some upstream branch
+
+3. Now you need to build and save a new Docker image to be used in CI.
+   This is done using the github UI
+
+   * Navigate to https://github.com/feldera/feldera/actions
+
+   * Click on `Docker CI Image` on the left (you can also get there directly
+   with https://github.com/feldera/feldera/actions/workflows/build-docker-dev.yml)
+
+   * Run the workflow (button "Run workflow" on top-right) on the branch you
+   used in step 2 above.
+
+   * When the workflow is finished it will publish the last Docker image here:
+   https://github.com/feldera/feldera-ci-test/pkgs/container/feldera-dev
+   You need to copy the long hash number corresponding to the new image and use
+   it in the next step.
+
+4. Change all the CI scripts to use the new Docker image.
+   These scripts are in .github/workflows/*.yaml
+
+   * For each script that contains a line similar to:
+
+```
+   container:
+    image: ghcr.io/feldera/feldera-dev:sha-2151999cad3499a8e87ba804ffa6750f925309d9
+```
+
+  you need to replace the hash value after the colon `:` with the new hash value.
+
+  At the time of writing these instructions there were 8 files involved, but this
+  may change.  You can get the list of files by `grep`-ing for the old hash value.
+
+  * `build-java.yml`
+  * `build-rust.yml`
+  * `ci-post-release.yml`
+  * `publish-crates.yml`
+  * `test-integration.yml`
+  * `test-java-nightly.yml`
+  * `test-java.yml`
+  * `test-unit.yml`
diff --git a/deploy/build.Dockerfile b/deploy/build.Dockerfile
@@ -18,6 +18,8 @@ RUN apt-get update --fix-missing && apt-get install -y \
     cmake \
     # rdkafka dependency needs libsasl2-dev and a CXX compiler
     libsasl2-dev build-essential \
+    # bindgen needs this (at least the dec crate uses bindgen)
+    libclang-dev \
     # To install rust
     curl  \
     # For running the SQL compiler
