py: remove default timeouts

abhizer · abhizer · commit 4b2017ebc4ec · 2025-10-16T13:07:35.000Z
Signed-off-by: Abhinav Gyawali &lt;22275402+abhizer@users.noreply.github.com&gt;
diff --git a/python/feldera/pipeline.py b/python/feldera/pipeline.py
@@ -300,7 +300,7 @@ def foreach_chunk(
         handler.start()
 
     def wait_for_completion(
-        self, force_stop: bool = False, timeout_s: Optional[float] = None
+        self, force_stop: bool = False, timeout_s: float | None = None
     ):
         """
         Block until the pipeline has completed processing all input records.
@@ -376,7 +376,7 @@ def is_complete(self) -> bool:
     def wait_for_idle(
         self,
         idle_interval_s: float = 5.0,
-        timeout_s: float = 600.0,
+        timeout_s: float | None = None,
         poll_interval_s: float = 0.2,
     ):
         """
@@ -396,12 +396,12 @@ def wait_for_idle(
         :raises RuntimeError: If the metrics are missing or the timeout was
             reached.
         """
-        if idle_interval_s > timeout_s:
+        if timeout_s is not None and idle_interval_s > timeout_s:
             raise ValueError(
                 f"idle interval ({idle_interval_s}s) cannot be larger than"
                 f" timeout ({timeout_s}s)"
             )
-        if poll_interval_s > timeout_s:
+        if timeout_s is not None and poll_interval_s > timeout_s:
             raise ValueError(
                 f"poll interval ({poll_interval_s}s) cannot be larger than"
                 f" timeout ({timeout_s}s)"
@@ -447,7 +447,7 @@ def wait_for_idle(
                 return
 
             # Timeout
-            if now_s - start_time_s >= timeout_s:
+            if timeout_s is not None and now_s - start_time_s >= timeout_s:
                 raise RuntimeError(f"waiting for idle reached timeout ({timeout_s}s)")
             time.sleep(poll_interval_s)
 
@@ -696,7 +696,7 @@ def get(name: str, client: FelderaClient) -> "Pipeline":
                 err.message = f"Pipeline with name {name} not found"
                 raise err
 
-    def checkpoint(self, wait: bool = False, timeout_s=300) -> int:
+    def checkpoint(self, wait: bool = False, timeout_s: Optional[float] = None) -> int:
         """
         Checkpoints this pipeline.
 
@@ -718,7 +718,7 @@ def checkpoint(self, wait: bool = False, timeout_s=300) -> int:
 
         while True:
             elapsed = time.monotonic() - start
-            if elapsed > timeout_s:
+            if timeout_s is not None and elapsed > timeout_s:
                 raise TimeoutError(
                     f"""timeout ({timeout_s}s) reached while waiting for \
 pipeline '{self.name}' to make checkpoint '{seq}'"""
@@ -754,7 +754,9 @@ def checkpoint_status(self, seq: int) -> CheckpointStatus:
         if seq < success:
             return CheckpointStatus.Unknown
 
-    def sync_checkpoint(self, wait: bool = False, timeout_s=300) -> str:
+    def sync_checkpoint(
+        self, wait: bool = False, timeout_s: Optional[float] = None
+    ) -> str:
         """
         Syncs this checkpoint to object store.
 
@@ -776,7 +778,7 @@ def sync_checkpoint(self, wait: bool = False, timeout_s=300) -> str:
 
         while True:
             elapsed = time.monotonic() - start
-            if elapsed > timeout_s:
+            if timeout_s is not None and elapsed > timeout_s:
                 raise TimeoutError(
                     f"""timeout ({timeout_s}s) reached while waiting for \
 pipeline '{self.name}' to sync checkpoint '{uuid}'"""
diff --git a/python/feldera/rest/_helpers.py b/python/feldera/rest/_helpers.py
@@ -20,20 +20,20 @@ def requests_verify_from_env() -> str | bool:
     if env_feldera_tls_insecure is not None and FELDERA_HTTPS_TLS_CERT is not None:
         logging.warning(
             "environment variables FELDERA_HTTPS_TLS_CERT and "
-            "FELDERA_TLS_INSECURE both are set."
-            "\nFELDERA_HTTPS_TLS_CERT takes priority."
+            + "FELDERA_TLS_INSECURE both are set."
+            + "\nFELDERA_HTTPS_TLS_CERT takes priority."
         )
 
     if env_feldera_tls_insecure is None:
-        FELDERA_TLS_INSECURE = False
+        feldera_tls_insecure = False
     else:
-        FELDERA_TLS_INSECURE = env_feldera_tls_insecure.strip().lower() in (
+        feldera_tls_insecure = env_feldera_tls_insecure.strip().lower() in (
             "1",
             "true",
             "yes",
         )
 
-    requests_verify = not FELDERA_TLS_INSECURE
+    requests_verify = not feldera_tls_insecure
     if FELDERA_HTTPS_TLS_CERT is not None:
         requests_verify = FELDERA_HTTPS_TLS_CERT
 
diff --git a/python/feldera/rest/_httprequests.py b/python/feldera/rest/_httprequests.py
@@ -56,7 +56,7 @@ def send_request(
         """
         self.headers["Content-Type"] = content_type
 
-        prev_resp: Optional[requests.Response] = None
+        prev_resp: requests.Response | None = None
 
         try:
             conn_timeout = self.config.connection_timeout
@@ -156,7 +156,7 @@ def post(
         body: Optional[
             Union[Mapping[str, Any], Sequence[Mapping[str, Any]], List[str], str]
         ] = None,
-        content_type: Optional[str] = "application/json",
+        content_type: str = "application/json",
         params: Optional[Mapping[str, Any]] = None,
         stream: bool = False,
         serialize: bool = True,
@@ -177,7 +177,7 @@ def patch(
         body: Optional[
             Union[Mapping[str, Any], Sequence[Mapping[str, Any]], List[str], str]
         ] = None,
-        content_type: Optional[str] = "application/json",
+        content_type: str = "application/json",
         params: Optional[Mapping[str, Any]] = None,
     ) -> Any:
         return self.send_request(requests.patch, path, body, content_type, params)
@@ -188,7 +188,7 @@ def put(
         body: Optional[
             Union[Mapping[str, Any], Sequence[Mapping[str, Any]], List[str], str]
         ] = None,
-        content_type: Optional[str] = "application/json",
+        content_type: str = "application/json",
         params: Optional[Mapping[str, Any]] = None,
     ) -> Any:
         return self.send_request(requests.put, path, body, content_type, params)
diff --git a/python/feldera/rest/config.py b/python/feldera/rest/config.py
@@ -39,7 +39,7 @@ def __init__(
         )
         self.url: str = BASE_URL
         self.api_key: Optional[str] = os.environ.get("FELDERA_API_KEY", api_key)
-        self.version: Optional[str] = version or "v0"
+        self.version: str = version or "v0"
         self.timeout: Optional[float] = timeout
         self.connection_timeout: Optional[float] = connection_timeout
         env_verify = requests_verify_from_env()
diff --git a/python/feldera/rest/feldera_client.py b/python/feldera/rest/feldera_client.py

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def __init__(`
`39`	`39`	`)`
`40`	`40`	`self.url: str = BASE_URL`
`41`	`41`	`self.api_key: Optional[str] = os.environ.get("FELDERA_API_KEY", api_key)`
`42`		`- self.version: Optional[str] = version or "v0"`
	`42`	`+ self.version: str = version or "v0"`
`43`	`43`	`self.timeout: Optional[float] = timeout`
`44`	`44`	`self.connection_timeout: Optional[float] = connection_timeout`
`45`	`45`	`env_verify = requests_verify_from_env()`