Skip to content

Commit 2a48540

Browse files
committed
Migrate to postgresql_embedded crate.
- pg-embed isn't really maintained anymore, and this one is. - Another reason is that this one happens to have binaries with the right alignment for ELF files for our new ARM CI machines (which have a 64KB default page-size), whereas ones from pg-embed align ELF section to 4K so our machines refuse to load them. - Another nice thing is that this one has a 'bundle' feature so we don't need the pre-install step anymore, so I removed it. We still need a fork sadly but I made a PR for them which will hopefully go in: theseus-rs/postgresql-embedded#188 Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
1 parent 0a9b4ef commit 2a48540

File tree

23 files changed

+501
-201
lines changed

23 files changed

+501
-201
lines changed

.devcontainer/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
FROM ubuntu:24.04 AS base
22

3-
## Add non-root user for startup of pg-embed with rust backend
3+
## Add non-root user for startup of postgres with rust backend
44

55
ARG USERNAME=user
66

77
RUN useradd -m $USERNAME && usermod -aG sudo $USERNAME
88
RUN echo "user:pass" | chpasswd
99

10-
# Set locale to fix pg-embed startup
10+
# Set locale to fix postgres embedded startup
1111
ENV LC_ALL=en_US.UTF-8
1212

1313
## Install common dependencies

.github/workflows/ci-post-release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,3 @@ jobs:
5555
with:
5656
message: "ci: Prepare for v${{ env.NEXT_VERSION }}"
5757
push: origin main
58-
default_author: user_info

.github/workflows/ci-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
sha:
77
description: "SHA to release (a recent commit from main that hasn't been released yet)"
88
schedule:
9-
- cron: "0 8 * * *" # Runs at 00:00 PT (08:00 UTC) daily
9+
- cron: "11 7 * * *" # Runs at 07:11 UTC daily
1010

1111
env:
1212
REGISTRY: ghcr.io

.github/workflows/test-java.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,5 @@ jobs:
3939
- name: Run mvn test
4040
run: mvn test --no-transfer-progress -q -B -pl SQL-compiler -Dsurefire.failIfNoSpecifiedTests=false
4141
working-directory: ./sql-to-dbsp-compiler
42+
env:
43+
RUSTFLAGS: ""

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ cargo_workspace
5353
# python
5454
__pycache__
5555

56-
# pg-embed directory
57-
/data
58-
5956
# clone of the benchmark repo
6057
gh-pages
6158

.vscode/settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"avaliable"
77
],
88
"rust-analyzer.cargo.features": [
9-
"pg-embed"
9+
"postgresql_embedded"
1010
],
1111
"[python]": {
1212
"editor.defaultFormatter": "ms-python.black-formatter"
@@ -31,4 +31,4 @@
3131
],
3232
"prettier.configPath": "web-console/.prettierrc",
3333
"svg.preview.background": "transparent"
34-
}
34+
}

0 commit comments

Comments
 (0)