python: account for status SqlCompiled in program compilation check

snkas · ryzhyk · commit 1378393f9426 · 2024-12-05T08:31:21.000-08:00
There are demo and benchmark Python scripts which use direct API calls
for program compilation. Some of them do not yet account for the new
status `SqlCompiled` that was introduced in the compiler rework, and
fail as a result. This failure is nondeterministic, as when there is
only one program, it would relatively quickly transition to
`CompilingRust` and as such there is only a chance of the script
observing the new status. This fixes it by adding an extra condition for
`SqlCompiled` in the check of whether compilation is still ongoing.

Signed-off-by: Simon Kassing &lt;simon.kassing@feldera.com&gt;
diff --git a/benchmark/feldera-sql/run.py b/benchmark/feldera-sql/run.py
@@ -409,6 +409,7 @@ def main():
             elif (
                 status != "Pending"
                 and status != "CompilingRust"
+                and status != "SqlCompiled"
                 and status != "CompilingSql"
             ):
                 raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/demo/project_demo01-TimeSeriesEnrich/run.py b/demo/project_demo01-TimeSeriesEnrich/run.py
@@ -105,6 +105,7 @@ def prepare_feldera(api_url, start_pipeline):
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/demo/project_demo03-GreenTrip/run.py b/demo/project_demo03-GreenTrip/run.py
@@ -87,6 +87,7 @@ def prepare_feldera(api_url, start_pipeline):
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/demo/project_demo04-SimpleSelect/run.py b/demo/project_demo04-SimpleSelect/run.py
@@ -81,6 +81,7 @@ def prepare_feldera(api_url, start_pipeline):
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/demo/project_demo06-SupplyChainTutorial/run.py b/demo/project_demo06-SupplyChainTutorial/run.py
@@ -168,6 +168,7 @@ def main():
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/demo/project_demo07-SnowflakeSink/run.py b/demo/project_demo07-SnowflakeSink/run.py
@@ -191,6 +191,7 @@ def prepare_feldera(api_url):
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/demo/steady/demo.py b/demo/steady/demo.py
@@ -76,6 +76,7 @@ def main():
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
diff --git a/scripts/compilation_speed_benchmark.py b/scripts/compilation_speed_benchmark.py
@@ -102,6 +102,7 @@ def compile(program_name, program, headers):
         elif (
             status != "Pending"
             and status != "CompilingRust"
+            and status != "SqlCompiled"
             and status != "CompilingSql"
         ):
             raise RuntimeError(f"Failed program compilation with status {status}")
