Typeof comparison should always use ===

tersmitten · tersmitten · commit bfb0eda78c65 · 2013-05-31T09:48:37.000+02:00
diff --git a/functions/_phpjs_shared/_phpjs_shared_bc.js b/functions/_phpjs_shared/_phpjs_shared_bc.js
@@ -1118,7 +1118,7 @@ function _phpjs_shared_bc () {
     },
 
     cint: function (v) {
-      if (typeof v == 'undefined') {
+      if (typeof v === 'undefined') {
         v = 0;
       }
       var x = parseInt(v, 10);
diff --git a/functions/array/array_walk_recursive.js b/functions/array/array_walk_recursive.js
@@ -12,11 +12,11 @@ function array_walk_recursive (array, funcname, userdata) {
   }
 
   for (key in array) {
-    if (typeof array[key] == 'object') {
+    if (typeof array[key] === 'object') {
       return this.array_walk_recursive(array[key], funcname, userdata);
     }
 
-    if (typeof userdata != 'undefined') {
+    if (typeof userdata !== 'undefined') {
       eval(funcname + '( array [key] , key , userdata  )');
     } else {
       eval(funcname + '(  userdata ) ');
diff --git a/functions/bc/bcadd.js b/functions/bc/bcadd.js
@@ -15,7 +15,7 @@ function bcadd (left_operand, right_operand, scale) {
 
   var first, second, result;
 
-  if (typeof scale == 'undefined') {
+  if (typeof scale === 'undefined') {
     scale = libbcmath.scale;
   }
   scale = ((scale < 0) ? 0 : scale);
diff --git a/functions/bc/bccomp.js b/functions/bc/bccomp.js
@@ -14,7 +14,7 @@ function bccomp (left_operand, right_operand, scale) {
   var libbcmath = this._phpjs_shared_bc();
 
   var first, second; //bc_num
-  if (typeof scale == 'undefined') {
+  if (typeof scale === 'undefined') {
     scale = libbcmath.scale;
   }
   scale = ((scale < 0) ? 0 : scale);
diff --git a/functions/bc/bcdiv.js b/functions/bc/bcdiv.js
@@ -20,7 +20,7 @@ function bcdiv (left_operand, right_operand, scale) {
 
   var first, second, result;
 
-  if (typeof scale == 'undefined') {
+  if (typeof scale === 'undefined') {
     scale = libbcmath.scale;
   }
   scale = ((scale < 0) ? 0 : scale);
diff --git a/functions/bc/bcmul.js b/functions/bc/bcmul.js
@@ -16,7 +16,7 @@ function bcmul (left_operand, right_operand, scale) {
 
   var first, second, result;
 
-  if (typeof scale == 'undefined') {
+  if (typeof scale === 'undefined') {
     scale = libbcmath.scale;
   }
   scale = ((scale < 0) ? 0 : scale);
diff --git a/functions/bc/bcsub.js b/functions/bc/bcsub.js
@@ -17,7 +17,7 @@ function bcsub (left_operand, right_operand, scale) {
 
   var first, second, result;
 
-  if (typeof scale == 'undefined') {
+  if (typeof scale === 'undefined') {
     scale = libbcmath.scale;
   }
   scale = ((scale < 0) ? 0 : scale);
diff --git a/functions/datetime/getdate.js b/functions/datetime/getdate.js
@@ -7,8 +7,8 @@ function getdate (timestamp) {
   // *     returns 1: {'seconds': 40, 'minutes': 58, 'hours': 21, 'mday': 17, 'wday': 2, 'mon': 6, 'year': 2003, 'yday': 167, 'weekday': 'Tuesday', 'month': 'June', '0': 1055901520}
   var _w = ['Sun', 'Mon', 'Tues', 'Wednes', 'Thurs', 'Fri', 'Satur'];
   var _m = ['January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December'];
-  var d = ((typeof timestamp == 'undefined') ? new Date() : // Not provided
-  (typeof timestamp == 'object') ? new Date(timestamp) : // Javascript Date()
+  var d = ((typeof timestamp === 'undefined') ? new Date() : // Not provided
+  (typeof timestamp === 'object') ? new Date(timestamp) : // Javascript Date()
   new Date(timestamp * 1000) // UNIX timestamp (auto-convert to int)
   );
   var w = d.getDay();
diff --git a/functions/datetime/gmstrftime.js b/functions/datetime/gmstrftime.js
@@ -6,8 +6,8 @@ function gmstrftime (format, timestamp) {
   // -    depends on: strftime
   // *     example 1: gmstrftime("%A", 1062462400);
   // *     returns 1: 'Tuesday'
-  var dt = ((typeof timestamp == 'undefined') ? new Date() : // Not provided
-  (typeof timestamp == 'object') ? new Date(timestamp) : // Javascript Date()
+  var dt = ((typeof timestamp === 'undefined') ? new Date() : // Not provided
+  (typeof timestamp === 'object') ? new Date(timestamp) : // Javascript Date()
   new Date(timestamp * 1000) // UNIX timestamp (auto-convert to int)
   );
   timestamp = Date.parse(dt.toUTCString().slice(0, -4)) / 1000;
diff --git a/functions/datetime/strftime.js b/functions/datetime/strftime.js
@@ -174,8 +174,8 @@ OW
 Oy
 */
 
-  var _date = ((typeof timestamp == 'undefined') ? new Date() : // Not provided
-  (typeof timestamp == 'object') ? new Date(timestamp) : // Javascript Date()
+  var _date = ((typeof timestamp === 'undefined') ? new Date() : // Not provided
+  (typeof timestamp === 'object') ? new Date(timestamp) : // Javascript Date()
   new Date(timestamp * 1000) // PHP API expects UNIX timestamp (auto-convert to int)
   );
 
diff --git a/functions/filesystem/basename.js b/functions/filesystem/basename.js
@@ -10,7 +10,7 @@ function basename (path, suffix) {
   // *     returns 2: 'ecra.php?p=1'
   var b = path.replace(/^.*[\/\\]/g, '');
 
-  if (typeof suffix == 'string' && b.substr(b.length - suffix.length) == suffix) {
+  if (typeof suffix === 'string' && b.substr(b.length - suffix.length) == suffix) {
     b = b.substr(0, b.length - suffix.length);
   }
 
diff --git a/functions/var/is_string.js b/functions/var/is_string.js
@@ -5,5 +5,5 @@ function is_string (mixed_var) {
   // *     returns 1: true
   // *     example 2: is_string(23.5);
   // *     returns 2: false
-  return (typeof mixed_var == 'string');
+  return (typeof mixed_var === 'string');
 }

Original file line number	Diff line number	Diff line change
`@@ -1118,7 +1118,7 @@ function _phpjs_shared_bc () {`
`1118`	`1118`	`},`
`1119`	`1119`
`1120`	`1120`	`cint: function (v) {`
`1121`		`- if (typeof v == 'undefined') {`
	`1121`	`+ if (typeof v === 'undefined') {`
`1122`	`1122`	`v = 0;`
`1123`	`1123`	`}`
`1124`	`1124`	`var x = parseInt(v, 10);`
Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,11 @@ function array_walk_recursive (array, funcname, userdata) {`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`for (key in array) {`
`15`		`- if (typeof array[key] == 'object') {`
	`15`	`+ if (typeof array[key] === 'object') {`
`16`	`16`	`return this.array_walk_recursive(array[key], funcname, userdata);`
`17`	`17`	`}`
`18`	`18`
`19`		`- if (typeof userdata != 'undefined') {`
	`19`	`+ if (typeof userdata !== 'undefined') {`
`20`	`20`	`eval(funcname + '( array [key] , key , userdata )');`
`21`	`21`	`} else {`
`22`	`22`	`eval(funcname + '( userdata ) ');`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ function bcadd (left_operand, right_operand, scale) {`
`15`	`15`
`16`	`16`	`var first, second, result;`
`17`	`17`
`18`		`- if (typeof scale == 'undefined') {`
	`18`	`+ if (typeof scale === 'undefined') {`
`19`	`19`	`scale = libbcmath.scale;`
`20`	`20`	`}`
`21`	`21`	`scale = ((scale < 0) ? 0 : scale);`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ function bccomp (left_operand, right_operand, scale) {`
`14`	`14`	`var libbcmath = this._phpjs_shared_bc();`
`15`	`15`
`16`	`16`	`var first, second; //bc_num`
`17`		`- if (typeof scale == 'undefined') {`
	`17`	`+ if (typeof scale === 'undefined') {`
`18`	`18`	`scale = libbcmath.scale;`
`19`	`19`	`}`
`20`	`20`	`scale = ((scale < 0) ? 0 : scale);`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ function bcdiv (left_operand, right_operand, scale) {`
`20`	`20`
`21`	`21`	`var first, second, result;`
`22`	`22`
`23`		`- if (typeof scale == 'undefined') {`
	`23`	`+ if (typeof scale === 'undefined') {`
`24`	`24`	`scale = libbcmath.scale;`
`25`	`25`	`}`
`26`	`26`	`scale = ((scale < 0) ? 0 : scale);`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ function bcmul (left_operand, right_operand, scale) {`
`16`	`16`
`17`	`17`	`var first, second, result;`
`18`	`18`
`19`		`- if (typeof scale == 'undefined') {`
	`19`	`+ if (typeof scale === 'undefined') {`
`20`	`20`	`scale = libbcmath.scale;`
`21`	`21`	`}`
`22`	`22`	`scale = ((scale < 0) ? 0 : scale);`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ function bcsub (left_operand, right_operand, scale) {`
`17`	`17`
`18`	`18`	`var first, second, result;`
`19`	`19`
`20`		`- if (typeof scale == 'undefined') {`
	`20`	`+ if (typeof scale === 'undefined') {`
`21`	`21`	`scale = libbcmath.scale;`
`22`	`22`	`}`
`23`	`23`	`scale = ((scale < 0) ? 0 : scale);`