Add ability use case insensitive headers for default Client (OpenFeign#1586)

selectee · Alexander Zadvinskiy · velo · web-flow · commit 7146e358e5fa · 2022-03-06T20:08:46.000Z
* Add ability use case insensitive headers for default Client

* Add ability use case insensitive headers for default Client

Co-authored-by: Alexander Zadvinskiy &lt;azadvinskiy@it-one.ru&gt;
Co-authored-by: Marvin Froeder &lt;velo@users.noreply.github.com&gt;
diff --git a/core/src/main/java/feign/Client.java b/core/src/main/java/feign/Client.java
@@ -20,6 +20,7 @@
 import static feign.Util.checkArgument;
 import static feign.Util.checkNotNull;
 import static feign.Util.isNotBlank;
+import static java.lang.String.CASE_INSENSITIVE_ORDER;
 import static java.lang.String.format;
 import feign.Request.Options;
 import java.io.IOException;
@@ -31,9 +32,9 @@
 import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 import java.util.Collection;
-import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.TreeMap;
 import java.util.zip.DeflaterOutputStream;
 import java.util.zip.GZIPInputStream;
 import java.util.zip.GZIPOutputStream;
@@ -114,7 +115,7 @@ Response convertResponse(HttpURLConnection connection, Request request) throws I
             connection.getRequestMethod(), connection.getURL()));
       }
 
-      Map<String, Collection<String>> headers = new LinkedHashMap<>();
+      Map<String, Collection<String>> headers = new TreeMap<>(CASE_INSENSITIVE_ORDER);
       for (Map.Entry<String, List<String>> field : connection.getHeaderFields().entrySet()) {
         // response message
         if (field.getKey() != null) {
@@ -130,9 +131,9 @@ Response convertResponse(HttpURLConnection connection, Request request) throws I
       if (status >= 400) {
         stream = connection.getErrorStream();
       } else {
-        if (this.isGzip(connection.getHeaderFields().get(CONTENT_ENCODING))) {
+        if (this.isGzip(headers.get(CONTENT_ENCODING))) {
           stream = new GZIPInputStream(connection.getInputStream());
-        } else if (this.isDeflate(connection.getHeaderFields().get(CONTENT_ENCODING))) {
+        } else if (this.isDeflate(headers.get(CONTENT_ENCODING))) {
           stream = new InflaterInputStream(connection.getInputStream());
         } else {
           stream = connection.getInputStream();
diff --git a/core/src/test/java/feign/client/DefaultClientTest.java b/core/src/test/java/feign/client/DefaultClientTest.java
@@ -170,6 +170,25 @@ public void canSupportGzip() throws Exception {
 
   }
 
+  @Test
+  public void canExeptCaseInsensitiveHeader() throws Exception {
+    /* enqueue a zipped response */
+    final String responseData = "Compressed Data";
+    server.enqueue(new MockResponse()
+        .addHeader("content-encoding", "gzip")
+        .setBody(new Buffer().write(compress(responseData))));
+
+    TestInterface api = newBuilder()
+        .target(TestInterface.class, "http://localhost:" + server.getPort());
+
+    String result = api.get();
+
+    /* verify that the response is unzipped */
+    assertThat(result).isNotNull()
+        .isEqualToIgnoringCase(responseData);
+
+  }
+
   @Test
   public void canSupportDeflate() throws Exception {
     /* enqueue a zipped response */
