Added functionallity for appending querystring params once the request is created

fernandezpablo85 · fernandezpablo85 · commit 7e92db34139b · 2011-01-09T15:44:14.000-03:00
diff --git a/src/main/java/org/scribe/model/Request.java b/src/main/java/org/scribe/model/Request.java
@@ -19,6 +19,7 @@ class Request
 
   private String url;
   private Verb verb;
+  private Map<String, String> querystringParams;
   private Map<String, String> bodyParams;
   private Map<String, String> headers;
   private String payload = null;
@@ -34,6 +35,7 @@ public Request(Verb verb, String url)
   {
     this.verb = verb;
     this.url = url;
+    this.querystringParams = new HashMap<String, String>();
     this.bodyParams = new HashMap<String, String>();
     this.headers = new HashMap<String, String>();
   }
@@ -111,6 +113,17 @@ public void addBodyParameter(String key, String value)
     this.bodyParams.put(key, value);
   }
 
+  /**
+   * Add a QueryString parameter
+   *
+   * @param key the parameter name
+   * @param value the parameter value
+   */
+  public void addQuerystringParam(String key, String value)
+  {
+    this.querystringParams.put(key, value);
+  }
+
   /**
    * Add body payload.
    * 
@@ -145,8 +158,10 @@ public Map<String, String> getQueryStringParams()
           params.put(pair[0], pair[1]);
         }
       }
+      params.putAll(querystringParams);
       return params;
-    } catch (MalformedURLException mue)
+    }
+    catch (MalformedURLException mue)
     {
       throw new OAuthException("Malformed URL", mue);
     }
diff --git a/src/test/java/org/scribe/model/RequestTest.java b/src/test/java/org/scribe/model/RequestTest.java
@@ -65,4 +65,13 @@ public void shouldSetPayloadAndHeaders()
     assertTrue(connection.getHeaders().containsKey("Content-Length"));
   }
 
+  @Test
+  public void shouldAllowAddingQuerystringParametersAfterCreation()
+  {
+    Request request = new Request(Verb.GET, "http://example.com?one=val");
+    request.addQuerystringParam("two", "other val");
+    request.addQuerystringParam("more", "params");
+    assertEquals(3, request.getQueryStringParams().size());
+  }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ class Request`
`19`	`19`
`20`	`20`	`private String url;`
`21`	`21`	`private Verb verb;`
	`22`	`+ private Map<String, String> querystringParams;`
`22`	`23`	`private Map<String, String> bodyParams;`
`23`	`24`	`private Map<String, String> headers;`
`24`	`25`	`private String payload = null;`
`@@ -34,6 +35,7 @@ public Request(Verb verb, String url)`
`34`	`35`	`{`
`35`	`36`	`this.verb = verb;`
`36`	`37`	`this.url = url;`
	`38`	`+ this.querystringParams = new HashMap<String, String>();`
`37`	`39`	`this.bodyParams = new HashMap<String, String>();`
`38`	`40`	`this.headers = new HashMap<String, String>();`
`39`	`41`	`}`
`@@ -111,6 +113,17 @@ public void addBodyParameter(String key, String value)`
`111`	`113`	`this.bodyParams.put(key, value);`
`112`	`114`	`}`
`113`	`115`
	`116`	`+ /**`
	`117`	`+ * Add a QueryString parameter`
	`118`	`+ *`
	`119`	`+ * @param key the parameter name`
	`120`	`+ * @param value the parameter value`
	`121`	`+ */`
	`122`	`+ public void addQuerystringParam(String key, String value)`
	`123`	`+ {`
	`124`	`+ this.querystringParams.put(key, value);`
	`125`	`+ }`
	`126`	`+`
`114`	`127`	`/**`
`115`	`128`	`* Add body payload.`
`116`	`129`	`*`
`@@ -145,8 +158,10 @@ public Map<String, String> getQueryStringParams()`
`145`	`158`	`params.put(pair[0], pair[1]);`
`146`	`159`	`}`
`147`	`160`	`}`
	`161`	`+ params.putAll(querystringParams);`
`148`	`162`	`return params;`
`149`		`- } catch (MalformedURLException mue)`
	`163`	`+ }`
	`164`	`+ catch (MalformedURLException mue)`
`150`	`165`	`{`
`151`	`166`	`throw new OAuthException("Malformed URL", mue);`
`152`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,4 +65,13 @@ public void shouldSetPayloadAndHeaders()`
`65`	`65`	`assertTrue(connection.getHeaders().containsKey("Content-Length"));`
`66`	`66`	`}`
`67`	`67`
	`68`	`+ @Test`
	`69`	`+ public void shouldAllowAddingQuerystringParametersAfterCreation()`
	`70`	`+ {`
	`71`	`+ Request request = new Request(Verb.GET, "http://example.com?one=val");`
	`72`	`+ request.addQuerystringParam("two", "other val");`
	`73`	`+ request.addQuerystringParam("more", "params");`
	`74`	`+ assertEquals(3, request.getQueryStringParams().size());`
	`75`	`+ }`
	`76`	`+`
`68`	`77`	`}`