Add support for YouTube shorts

matthiask · matthiask · commit e78afe8356d9 · 2022-05-12T16:20:03.000+02:00
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -10,6 +10,8 @@ Change log
 
 - Fixed the ``APPEND_SLASH`` handling to also use ``request.path_info``, not
   ``request.path``.
+- Added support for embedding YouTube shorts when using
+  :mod:`feincms3.embedding`.
 
 
 `3.5`_ (2022-04-11)
diff --git a/feincms3/embedding.py b/feincms3/embedding.py
@@ -13,7 +13,7 @@
 YOUTUBE_RE = re.compile(
     r"""youtu(\.?)be(\.com)?/  # match youtube's domains
         (\#/)? # for mobile urls
-        (embed/)?  # match the embed url syntax
+        (embed/|shorts/|watch/)?  # match the embed/shorts/watch url syntax
         (v/)?
         (watch\?v=)?  # match the youtube page url
         (ytscreeningroom\?v=)?
diff --git a/tests/testapp/test_embedding.py b/tests/testapp/test_embedding.py
@@ -34,6 +34,8 @@ def test_youtube(self):
                 "https://www.youtube.com/watch?v=DYu_bGbZiiQ&list=RDJMOOG7rWTPg&index=7"
             )
         )
+        self.assertTrue(embed("https://www.youtube.com/watch/ZumRshfKdtM"))
+        self.assertTrue(embed("https://www.youtube.com/shorts/ZumRshfKdtM"))
 
     def test_vimeo(self):
         """Vimeo video embedding works"""

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,8 @@ def test_youtube(self):`
`34`	`34`	`"https://www.youtube.com/watch?v=DYu_bGbZiiQ&list=RDJMOOG7rWTPg&index=7"`
`35`	`35`	`)`
`36`	`36`	`)`
	`37`	`+ self.assertTrue(embed("https://www.youtube.com/watch/ZumRshfKdtM"))`
	`38`	`+ self.assertTrue(embed("https://www.youtube.com/shorts/ZumRshfKdtM"))`
`37`	`39`
`38`	`40`	`def test_vimeo(self):`
`39`	`41`	`"""Vimeo video embedding works"""`