Add on_delete to foreign keys

matthiask · matthiask · commit d7a09c425c15 · 2016-11-19T13:00:49.000+01:00
diff --git a/feincms/extensions/translations.py b/feincms/extensions/translations.py
@@ -167,6 +167,7 @@ def handle_model(self):
             'translation_of',
             models.ForeignKey(
                 'self',
+                on_delete=models.CASCADE,
                 blank=True, null=True, verbose_name=_('translation of'),
                 related_name='translations',
                 limit_choices_to={'language': django_settings.LANGUAGES[0][0]},
diff --git a/feincms/models.py b/feincms/models.py
@@ -517,7 +517,8 @@ def get_queryset(cls, filter_args):
                 'render': render,
                 'get_queryset': classmethod(get_queryset),
                 'Meta': Meta,
-                'parent': models.ForeignKey(cls, related_name='%(class)s_set'),
+                'parent': models.ForeignKey(
+                    cls, related_name='%(class)s_set', on_delete=models.CASCADE),
                 'region': models.CharField(max_length=255),
                 'ordering': models.IntegerField(_('ordering'), default=0),
             }
diff --git a/feincms/module/medialibrary/models.py b/feincms/module/medialibrary/models.py
@@ -45,6 +45,7 @@ class Category(models.Model):
     title = models.CharField(_('title'), max_length=200)
     parent = models.ForeignKey(
         'self', blank=True, null=True,
+        on_delete=models.CASCADE,
         related_name='children', limit_choices_to={'parent__isnull': True},
         verbose_name=_('parent'))
 
diff --git a/feincms/module/page/extensions/sites.py b/feincms/module/page/extensions/sites.py
@@ -18,7 +18,8 @@ def handle_model(self):
         self.model.add_to_class(
             'site',
             models.ForeignKey(
-                Site, verbose_name=_('Site'), default=settings.SITE_ID))
+                Site, verbose_name=_('Site'), default=settings.SITE_ID,
+                on_delete=models.CASCADE))
 
         PageManager.add_to_active_filters(current_site, key='current_site')
 
diff --git a/feincms/module/page/extensions/symlinks.py b/feincms/module/page/extensions/symlinks.py
@@ -18,6 +18,7 @@ def handle_model(self):
             'self',
             blank=True,
             null=True,
+            on_delete=models.CASCADE,
             related_name='%(app_label)s_%(class)s_symlinks',
             verbose_name=_('symlinked page'),
             help_text=_('All content is inherited from this page if given.')))
diff --git a/feincms/module/page/models.py b/feincms/module/page/models.py
@@ -159,6 +159,7 @@ class BasePage(create_base_model(MPTTModel), ContentModelMixin):
         help_text=_('This is used to build the URL for this page'))
     parent = models.ForeignKey(
         'self', verbose_name=_('Parent'), blank=True,
+        on_delete=models.CASCADE,
         null=True, related_name='children')
     # Custom list_filter - see admin/filterspecs.py
     parent.parent_filter = True
diff --git a/feincms/translations.py b/feincms/translations.py
@@ -277,7 +277,8 @@ def Translation(model):
     """
 
     class Inner(models.Model):
-        parent = models.ForeignKey(model, related_name='translations')
+        parent = models.ForeignKey(
+            model, related_name='translations', on_delete=models.CASCADE)
         language_code = models.CharField(
             _('language'), max_length=10,
             choices=settings.LANGUAGES, default=settings.LANGUAGES[0][0],
diff --git a/tests/testapp/models.py b/tests/testapp/models.py
@@ -88,7 +88,8 @@ class Category(MPTTModel):
     name = models.CharField(max_length=20)
     slug = models.SlugField()
     parent = models.ForeignKey(
-        'self', blank=True, null=True, related_name='children')
+        'self', blank=True, null=True, related_name='children',
+        on_delete=models.CASCADE)
 
     class Meta:
         ordering = ['tree_id', 'lft']
