Run project througn sonar, fix a couple of minor issues:

Martin J. Laubach · Martin J. Laubach · commit a9cb72cd502a · 2024-09-06T10:18:00.000+02:00
Variable names shadowing builtins, wrong param name for class method, duplicated css rules, accessibility
diff --git a/feincms/content/application/models.py b/feincms/content/application/models.py
@@ -441,7 +441,7 @@ def _update_response_headers(self, request, response, headers):
                 )
 
     @classmethod
-    def app_reverse_cache_key(self, urlconf_path, **kwargs):
+    def app_reverse_cache_key(cls, urlconf_path, **kwargs):
         return "FEINCMS:{}:APPCONTENT:{}:{}".format(
             getattr(settings, "SITE_ID", 0),
             get_language(),
diff --git a/feincms/content/image/models.py b/feincms/content/image/models.py
@@ -67,12 +67,12 @@ def render(self, **kwargs):
         return AutoRenderTuple((templates, {"content": self}))
 
     def get_image(self):
-        type, separator, size = getattr(self, "format", "").partition(":")
+        img_type, _, size = getattr(self, "format", "").partition(":")
         if not size:
             return self.image
 
         thumbnailer = {"cropscale": feincms_thumbnail.CropscaleThumbnailer}.get(
-            type, feincms_thumbnail.Thumbnailer
+            img_type, feincms_thumbnail.Thumbnailer
         )
         return thumbnailer(self.image, size)
 
diff --git a/feincms/extensions/ct_tracker.py b/feincms/extensions/ct_tracker.py
@@ -1,5 +1,4 @@
 # ------------------------------------------------------------------------
-# ------------------------------------------------------------------------
 #
 #  ct_tracker.py
 #  FeinCMS
@@ -82,18 +81,18 @@ def _translation_map(self):
             # done late as opposed to at class definition time as not all
             # information is ready, especially when we are doing a "syncdb" the
             # ContentType table does not yet exist
-            map = {}
+            tmap = {}
             model_to_contenttype = ContentType.objects.get_for_models(
                 *self.item._feincms_content_types
             )
             for idx, fct in enumerate(self.item._feincms_content_types):
                 dct = model_to_contenttype[fct]
 
                 # Rely on non-negative primary keys
-                map[-dct.id] = idx  # From-inventory map
-                map[idx] = dct.id  # To-inventory map
+                tmap[-dct.id] = idx  # From-inventory map
+                tmap[idx] = dct.id  # To-inventory map
 
-            _translation_map_cache[cls] = map
+            _translation_map_cache[cls] = tmap
         return _translation_map_cache[cls]
 
     def _from_inventory(self, inventory):
@@ -102,10 +101,10 @@ def _from_inventory(self, inventory):
         ContentProxy counts format.
         """
 
-        map = self._translation_map()
+        tmap = self._translation_map()
 
         return {
-            region: [(pk, map[-ct]) for pk, ct in items]
+            region: [(pk, tmap[-ct]) for pk, ct in items]
             for region, items in inventory.items()
             if region != "_version_"
         }
diff --git a/feincms/static/feincms/item_editor.css b/feincms/static/feincms/item_editor.css
@@ -133,15 +133,13 @@ textarea {
 
 .machine-control {
   padding: 5px 10px 5px 10px;
-  border: 1px solid #ccc;
-  background-color: #edf3fe;
+  border: 1px solid #eee;
+  background-color: #f8f8f8;
   position: absolute;
   left: -11px;
   bottom: -30px;
   width: 100%;
 
-  background: #f8f8f8;
-  border: 1px solid #eee;
   height: 55px;
 }
 
diff --git a/feincms/templates/content/video/vimeo.html b/feincms/templates/content/video/vimeo.html
@@ -1,2 +1,2 @@
-<iframe src="//player.vimeo.com/video/{{ id }}" width="650" height="365"
+<iframe src="//player.vimeo.com/video/{{ id }}" title="Video Player" width="650" height="365"
 frameborder="0" webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ def _update_response_headers(self, request, response, headers):`
`441`	`441`	`)`
`442`	`442`
`443`	`443`	`@classmethod`
`444`		`- def app_reverse_cache_key(self, urlconf_path, **kwargs):`
	`444`	`+ def app_reverse_cache_key(cls, urlconf_path, **kwargs):`
`445`	`445`	`return "FEINCMS:{}:APPCONTENT:{}:{}".format(`
`446`	`446`	`getattr(settings, "SITE_ID", 0),`
`447`	`447`	`get_language(),`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		`-<iframe src="//player.vimeo.com/video/{{ id }}" width="650" height="365"`
	`1`	`+<iframe src="//player.vimeo.com/video/{{ id }}" title="Video Player" width="650" height="365"`
`2`	`2`	`frameborder="0" webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>`