Prevent double submission on template change

hey-granth · hey-granth · commit 79b6db9266cb · 2026-02-10T21:07:56.000+05:30
- Disable all submit buttons (input and button elements) immediately after
  triggering save when template is changed in the admin interface
- Add regression test that verifies the fix is present in item_editor.js
- Test uses BASEDIR from settings for robust path construction

This prevents users from accidentally submitting the form twice while
the page is reloading after a template change.
diff --git a/feincms/static/feincms/item_editor.js b/feincms/static/feincms/item_editor.js
@@ -537,7 +537,7 @@
                    invoked. See Issue #372 */
         form_element.find("[type=submit][name=_save]").click()
         /* Disable all submit buttons to prevent double submission while page reloads */
-        form_element.find("input[type=submit]").attr("disabled", "disabled")
+        form_element.find("input[type=submit], button").attr("disabled", "disabled")
       } else {
         // Restore original value
         form_element.val($(this).data("original_value"))
diff --git a/tests/testapp/tests/test_template_change_fix.py b/tests/testapp/tests/test_template_change_fix.py
@@ -5,6 +5,7 @@
 """
 
 import os
+from django.conf import settings
 from django.test import TestCase
 
 
@@ -13,21 +14,19 @@ class TemplateChangeFixTest(TestCase):
 
     def test_fix_is_present_in_javascript(self):
         """Verify that the fix line exists in item_editor.js"""
-        # Get the path to the JavaScript file
-        base_dir = os.path.dirname(
-            os.path.dirname(os.path.dirname(os.path.dirname(__file__)))
-        )
+        # Use BASEDIR from settings to construct the path
         js_file_path = os.path.join(
-            base_dir, "feincms", "static", "feincms", "item_editor.js"
+            settings.BASEDIR, '..', '..', 'feincms', 'static', 'feincms', 'item_editor.js'
         )
+        js_file_path = os.path.normpath(js_file_path)
 
         # Read the file
         with open(js_file_path, "r") as f:
             content = f.read()
 
         # Check that the fix is present
         self.assertIn(
-            'form_element.find("input[type=submit]").attr("disabled", "disabled")',
+            'form_element.find("input[type=submit], button").attr("disabled", "disabled")',
             content,
             "The double submission fix should be present in item_editor.js",
         )
@@ -48,23 +47,18 @@ def test_fix_is_present_in_javascript(self):
 
     def test_fix_order_is_correct(self):
         """Verify that the disable happens AFTER the click, not before."""
-        base_dir = os.path.dirname(
-            os.path.dirname(os.path.dirname(os.path.dirname(__file__)))
-        )
+        base_dir = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))
         js_file_path = os.path.join(
-            base_dir, "feincms", "static", "feincms", "item_editor.js"
+            base_dir, 'feincms', 'static', 'feincms', 'item_editor.js'
         )
+        js_file_path = os.path.normpath(js_file_path)
 
         with open(js_file_path, "r") as f:
             content = f.read()
 
         # Find positions of both statements
-        click_pos = content.find(
-            'form_element.find("[type=submit][name=_save]").click()'
-        )
-        disable_pos = content.find(
-            'form_element.find("input[type=submit]").attr("disabled", "disabled")'
-        )
+        click_pos = content.find('form_element.find("[type=submit][name=_save]").click()')
+        disable_pos = content.find('form_element.find("input[type=submit]").attr("disabled", "disabled")')
 
         self.assertGreater(click_pos, 0, "The click() statement should be present")
         self.assertGreater(disable_pos, 0, "The disable statement should be present")
