Merge pull request microsoft#992 from Microsoft/perfWork

CyrusNajmabadi · CyrusNajmabadi · commit 5ce3baf339e0 · 2014-10-29T14:51:41.000-07:00
use .pop() on an array instead of setting the length directly.  The latt...
diff --git a/src/services/syntax/scanner.ts b/src/services/syntax/scanner.ts
@@ -1628,13 +1628,12 @@ module TypeScript.Scanner {
                 var diagnostic = _tokenDiagnostics[tokenDiagnosticsLength - 1];
                 if (diagnostic.start() >= position) {
                     tokenDiagnosticsLength--;
+                    _tokenDiagnostics.pop();
                 }
                 else {
                     break;
                 }
             }
-
-            _tokenDiagnostics.length = tokenDiagnosticsLength;
         }
 
         function resetToPosition(absolutePosition: number): void {

Original file line number	Diff line number	Diff line change
`@@ -1628,13 +1628,12 @@ module TypeScript.Scanner {`
`1628`	`1628`	`var diagnostic = _tokenDiagnostics[tokenDiagnosticsLength - 1];`
`1629`	`1629`	`if (diagnostic.start() >= position) {`
`1630`	`1630`	`tokenDiagnosticsLength--;`
	`1631`	`+ _tokenDiagnostics.pop();`
`1631`	`1632`	`}`
`1632`	`1633`	`else {`
`1633`	`1634`	`break;`
`1634`	`1635`	`}`
`1635`	`1636`	`}`
`1636`		`-`
`1637`		`- _tokenDiagnostics.length = tokenDiagnosticsLength;`
`1638`	`1637`	`}`
`1639`	`1638`
`1640`	`1639`	`function resetToPosition(absolutePosition: number): void {`