Skip to content

Commit 309891a

Browse files
committed
Fixes mgonto#955
1 parent f0a3a93 commit 309891a

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

src/restangular.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,13 +1198,13 @@ module.provider('Restangular', function() {
11981198
deferred.reject(response);
11991199
}
12001200
};
1201-
// Overring HTTP Method
1201+
// Overriding HTTP Method
12021202
var callOperation = operation;
12031203
var callHeaders = _.extend({}, request.headers);
12041204
var isOverrideOperation = config.isOverridenMethod(operation);
12051205
if (isOverrideOperation) {
12061206
callOperation = 'post';
1207-
callHeaders = _.extend(callHeaders, {'X-HTTP-Method-Override': operation === 'remove' ? 'DELETE' : operation});
1207+
callHeaders = _.extend(callHeaders, {'X-HTTP-Method-Override': operation === 'remove' ? 'DELETE' : operation.toUpperCase()});
12081208
} else if (config.jsonp && callOperation === 'get') {
12091209
callOperation = 'jsonp';
12101210
}

test/restangularSpec.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -883,14 +883,22 @@ describe("Restangular", function() {
883883
});
884884
});
885885

886-
describe("defaultHeaders", function() {
886+
describe("headers", function() {
887887
it("should return defaultHeaders", function() {
888888
var defaultHeaders = {testheader:'header value'};
889-
890889
Restangular.setDefaultHeaders(defaultHeaders);
891-
892890
expect(Restangular.defaultHeaders).toEqual(defaultHeaders);
893891
});
892+
893+
it("should pass uppercase methods in X-HTTP-Method-Override", function() {
894+
Restangular.setMethodOverriders(["put"]);
895+
$httpBackend.expectPOST('/overriders/1').respond(function(method, url, data, headers) {
896+
expect(headers['X-HTTP-Method-Override']).toBe('PUT');
897+
return {};
898+
});
899+
Restangular.one('overriders', 1).put();
900+
$httpBackend.flush();
901+
});
894902
});
895903

896904
describe("defaultRequestParams", function() {

0 commit comments

Comments
 (0)