Don't late bind Interface types

mythz · mythz · commit a8034d26e8b1 · 2012-02-12T16:11:10.000-05:00
diff --git a/NuGet/lib/ServiceStack.Text.dll b/NuGet/lib/ServiceStack.Text.dll
diff --git a/NuGet/servicestack.text.nuspec b/NuGet/servicestack.text.nuspec
@@ -2,7 +2,7 @@
 <package xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <metadata xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
     <id>ServiceStack.Text</id> 
-    <version>3.4.8</version> 
+    <version>3.4.9</version> 
     <authors>Demis Bellot</authors> 
     <owners>Demis Bellot</owners>
     <summary>.NET's fastest JSON, JSV and CSV Text Serializers (3x faster than JSON.NET)</summary>
diff --git a/src/ServiceStack.Text/Common/WriteType.cs b/src/ServiceStack.Text/Common/WriteType.cs
@@ -36,7 +36,10 @@ static WriteType()
 			if (typeof(T).IsAbstract)
 			{
 				WriteTypeInfo = TypeInfoWriter;
-				CacheFn = WriteAbstractProperties;
+				if (!typeof(T).IsInterface)
+				{
+					CacheFn = WriteAbstractProperties;
+				}
 			}
 		}
 
@@ -163,7 +166,14 @@ public static void WriteAbstractProperties(TextWriter writer, object value)
 				writer.Write(JsWriter.EmptyMap);
 				return;
 			}
-			var writeFn = Serializer.GetWriteFn(value.GetType());			
+			var valueType = value.GetType();
+			if (valueType.IsAbstract)
+			{
+				WriteProperties(writer, value);
+				return;
+			}
+
+			var writeFn = Serializer.GetWriteFn(valueType);			
 			if (!JsConfig<T>.ExcludeTypeInfo) JsState.IsWritingDynamic = true;
 			writeFn(writer, value);
 			if (!JsConfig<T>.ExcludeTypeInfo) JsState.IsWritingDynamic = false;
diff --git a/src/ServiceStack.Text/Properties/AssemblyInfo.cs b/src/ServiceStack.Text/Properties/AssemblyInfo.cs
@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("3.4.8.*")]
+[assembly: AssemblyVersion("3.4.9.*")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
diff --git a/tests/ServiceStack.Text.Tests/AdhocModelTests.cs b/tests/ServiceStack.Text.Tests/AdhocModelTests.cs
@@ -289,7 +289,7 @@ public class Child
 			public IParent Parent { get; set; }
 		}
 
-		[Test, Ignore]
+		[Test]
 		public void Can_Serailize_Cyclical_Dependency_via_interface()
 		{
 			var dto = new Parent {

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ public class Child`
`289`	`289`	`public IParent Parent { get; set; }`
`290`	`290`	`}`
`291`	`291`
`292`		`- [Test, Ignore]`
	`292`	`+ [Test]`
`293`	`293`	`public void Can_Serailize_Cyclical_Dependency_via_interface()`
`294`	`294`	`{`
`295`	`295`	`var dto = new Parent {`