Remove JsConfig.ReuseStringBuffer always reuse cached instances

mythz · mythz · commit 5a141b75708b · 2016-04-21T01:42:57.000-04:00
diff --git a/src/ServiceStack.Text/JsConfig.cs b/src/ServiceStack.Text/JsConfig.cs
@@ -1,8 +1,6 @@
 using System;
-using System.Linq;
 using System.Collections.Generic;
 using System.IO;
-using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Threading;
 using ServiceStack.Text.Common;
@@ -129,10 +127,6 @@ public static JsConfigScope CreateScope(string config, JsConfigScope scope = nul
                     case "includepublicfields":
                         scope.IncludePublicFields = boolValue;
                         break;
-                    case "rsb":
-                    case "reuseStringBuffer":
-                        scope.ReuseStringBuffer = boolValue;
-                        break;
                     case "dh":
                     case "datehandler":
                         switch (value)
@@ -232,7 +226,6 @@ public static JsConfigScope With(
             bool? appendUtcOffset = null,
             bool? escapeUnicode = null,
             bool? includePublicFields = null,
-            bool? reuseStringBuffer = null,
             int? maxDepth = null,
             EmptyCtorFactoryDelegate modelFactory = null,
             string[] excludePropertyReferences = null)
@@ -269,7 +262,6 @@ public static JsConfigScope With(
                 AppendUtcOffset = appendUtcOffset ?? sAppendUtcOffset,
                 EscapeUnicode = escapeUnicode ?? sEscapeUnicode,
                 IncludePublicFields = includePublicFields ?? sIncludePublicFields,
-                ReuseStringBuffer = reuseStringBuffer ?? sReuseStringBuffer,
                 MaxDepth = maxDepth ?? sMaxDepth,
                 ModelFactory = modelFactory ?? ModelFactory,
                 ExcludePropertyReferences = excludePropertyReferences ?? sExcludePropertyReferences
@@ -829,25 +821,6 @@ public static bool IncludePublicFields
             }
         }
 
-        /// <summary>
-        /// For extra serialization performance you can re-use a ThreadStatic StringBuilder
-        /// when serializing to a JSON String.
-        /// </summary>
-        private static bool? sReuseStringBuffer;
-        public static bool ReuseStringBuffer
-        {
-            get
-            {
-                return (JsConfigScope.Current != null ? JsConfigScope.Current.ReuseStringBuffer : null)
-                    ?? sReuseStringBuffer
-                    ?? true;
-            }
-            set
-            {
-                if (!sReuseStringBuffer.HasValue) sReuseStringBuffer = value;
-            }
-        }
-
         /// <summary>
         /// Sets the maximum depth to avoid circular dependencies
         /// </summary>
@@ -963,7 +936,6 @@ public static void Reset()
             sEscapeUnicode = null;
             sOnDeserializationError = null;
             sIncludePublicFields = null;
-            sReuseStringBuffer = null;
             HasSerializeFn = new HashSet<Type>();
             HasIncludeDefaultValue = new HashSet<Type>();
             TreatValueAsRefTypes = new HashSet<Type> { typeof(KeyValuePair<,>) };
diff --git a/src/ServiceStack.Text/JsConfigScope.cs b/src/ServiceStack.Text/JsConfigScope.cs
@@ -78,7 +78,6 @@ public void Dispose()
         public bool? EscapeUnicode { get; set; }
         public bool? PreferInterfaces { get; set; }
         public bool? IncludePublicFields { get; set; }
-        public bool? ReuseStringBuffer { get; set; }
         public int? MaxDepth { get; set; }
         public DeserializationErrorDelegate OnDeserializationError { get; set; }
         public EmptyCtorFactoryDelegate ModelFactory { get; set; }
