Change to Ext method SplitFirst to SplitOnFirst

mythz · mythz · commit 25ca8f9e5d6a · 2011-01-27T01:27:00.000Z
diff --git a/src/ServiceStack.Text/StringExtensions.cs b/src/ServiceStack.Text/StringExtensions.cs
@@ -299,7 +299,7 @@ private static byte[] FastToUtf8Bytes(string strVal)
 			return bytes;
 		}
 
-		public static string[] SplitFirst(this string strVal, char needle)
+		public static string[] SplitOnFirst(this string strVal, char needle)
 		{
 			if (strVal == null) return new string[0];
 			var pos = strVal.IndexOf(needle);
@@ -308,7 +308,7 @@ public static string[] SplitFirst(this string strVal, char needle)
 				: new[] { strVal.Substring(0, pos), strVal.Substring(pos + 1) };
 		}
 
-		public static string[] SplitFirst(this string strVal, string needle)
+		public static string[] SplitOnFirst(this string strVal, string needle)
 		{
 			if (strVal == null) return new string[0];
 			var pos = strVal.IndexOf(needle);
diff --git a/tests/ServiceStack.Text.Tests/StringExtensionsTests.cs b/tests/ServiceStack.Text.Tests/StringExtensionsTests.cs
@@ -6,17 +6,17 @@ namespace ServiceStack.Text.Tests
 	public class StringExtensionsTests
 	{
 		[Test]
-		public void Can_SplitFirst_char_needle()
+		public void Can_SplitOnFirst_char_needle()
 		{
-			var parts = "user:pass@w:rd".SplitFirst(':');
+			var parts = "user:pass@w:rd".SplitOnFirst(':');
 			Assert.That(parts[0], Is.EqualTo("user"));
 			Assert.That(parts[1], Is.EqualTo("pass@w:rd"));
 		}
 
 		[Test]
-		public void Can_SplitFirst_string_needle()
+		public void Can_SplitOnFirst_string_needle()
 		{
-			var parts = "user:pass@w:rd".SplitFirst(":");
+			var parts = "user:pass@w:rd".SplitOnFirst(":");
 			Assert.That(parts[0], Is.EqualTo("user"));
 			Assert.That(parts[1], Is.EqualTo("pass@w:rd"));
 		}

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ private static byte[] FastToUtf8Bytes(string strVal)`
`299`	`299`	`return bytes;`
`300`	`300`	`}`
`301`	`301`
`302`		`- public static string[] SplitFirst(this string strVal, char needle)`
	`302`	`+ public static string[] SplitOnFirst(this string strVal, char needle)`
`303`	`303`	`{`
`304`	`304`	`if (strVal == null) return new string[0];`
`305`	`305`	`var pos = strVal.IndexOf(needle);`
`@@ -308,7 +308,7 @@ public static string[] SplitFirst(this string strVal, char needle)`
`308`	`308`	`: new[] { strVal.Substring(0, pos), strVal.Substring(pos + 1) };`
`309`	`309`	`}`
`310`	`310`
`311`		`- public static string[] SplitFirst(this string strVal, string needle)`
	`311`	`+ public static string[] SplitOnFirst(this string strVal, string needle)`
`312`	`312`	`{`
`313`	`313`	`if (strVal == null) return new string[0];`
`314`	`314`	`var pos = strVal.IndexOf(needle);`
Original file line number	Diff line number	Diff line change
`@@ -6,17 +6,17 @@ namespace ServiceStack.Text.Tests`
`6`	`6`	`public class StringExtensionsTests`
`7`	`7`	`{`
`8`	`8`	`[Test]`
`9`		`- public void Can_SplitFirst_char_needle()`
	`9`	`+ public void Can_SplitOnFirst_char_needle()`
`10`	`10`	`{`
`11`		`- var parts = "user:pass@w:rd".SplitFirst(':');`
	`11`	`+ var parts = "user:pass@w:rd".SplitOnFirst(':');`
`12`	`12`	`Assert.That(parts[0], Is.EqualTo("user"));`
`13`	`13`	`Assert.That(parts[1], Is.EqualTo("pass@w:rd"));`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`[Test]`
`17`		`- public void Can_SplitFirst_string_needle()`
	`17`	`+ public void Can_SplitOnFirst_string_needle()`
`18`	`18`	`{`
`19`		`- var parts = "user:pass@w:rd".SplitFirst(":");`
	`19`	`+ var parts = "user:pass@w:rd".SplitOnFirst(":");`
`20`	`20`	`Assert.That(parts[0], Is.EqualTo("user"));`
`21`	`21`	`Assert.That(parts[1], Is.EqualTo("pass@w:rd"));`
`22`	`22`	`}`