f2fs: fix a missing size change in f2fs_setattr

Yunlei He · Jaegeuk Kim · commit c0ed4405a99e · 2016-12-12T11:09:05.000-08:00
This patch fix a missing size change in f2fs_setattr

Signed-off-by: Yunlei He &lt;heyunlei@huawei.com&gt;
Reviewed-by: Chao Yu &lt;yuchao0@huawei.com&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
@@ -677,6 +677,7 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr)
 {
 	struct inode *inode = d_inode(dentry);
 	int err;
+	bool size_changed = false;
 
 	err = setattr_prepare(dentry, attr);
 	if (err)
@@ -707,6 +708,8 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr)
 			}
 			inode->i_mtime = inode->i_ctime = current_time(inode);
 		}
+
+		size_changed = true;
 	}
 
 	__setattr_copy(inode, attr);
@@ -719,8 +722,8 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr)
 		}
 	}
 
-	/* update attributes only */
-	f2fs_mark_inode_dirty_sync(inode, false);
+	/* file size may changed here */
+	f2fs_mark_inode_dirty_sync(inode, size_changed);
 
 	/* inode change will produce dirty node pages flushed by checkpoint */
 	f2fs_balance_fs(F2FS_I_SB(inode), true);

Original file line number	Diff line number	Diff line change
`@@ -677,6 +677,7 @@ int f2fs_setattr(struct dentry dentry, struct iattr attr)`
`677`	`677`	`{`
`678`	`678`	`struct inode *inode = d_inode(dentry);`
`679`	`679`	`int err;`
	`680`	`+ bool size_changed = false;`
`680`	`681`
`681`	`682`	`err = setattr_prepare(dentry, attr);`
`682`	`683`	`if (err)`
`@@ -707,6 +708,8 @@ int f2fs_setattr(struct dentry dentry, struct iattr attr)`
`707`	`708`	`}`
`708`	`709`	`inode->i_mtime = inode->i_ctime = current_time(inode);`
`709`	`710`	`}`
	`711`	`+`
	`712`	`+ size_changed = true;`
`710`	`713`	`}`
`711`	`714`
`712`	`715`	`__setattr_copy(inode, attr);`
`@@ -719,8 +722,8 @@ int f2fs_setattr(struct dentry dentry, struct iattr attr)`
`719`	`722`	`}`
`720`	`723`	`}`
`721`	`724`
`722`		`- /* update attributes only */`
`723`		`- f2fs_mark_inode_dirty_sync(inode, false);`
	`725`	`+ /* file size may changed here */`
	`726`	`+ f2fs_mark_inode_dirty_sync(inode, size_changed);`
`724`	`727`
`725`	`728`	`/* inode change will produce dirty node pages flushed by checkpoint */`
`726`	`729`	`f2fs_balance_fs(F2FS_I_SB(inode), true);`